From 50317f6789d041b5b9ae57ca67097e4fca7364f1 Mon Sep 17 00:00:00 2001 From: Jose Luis Marti Date: Tue, 23 Apr 2024 22:47:19 +0200 Subject: [PATCH 1/4] Remove obsolete params layout_centerHorizontal and layout_alignParentTop --- tools/android/packaging/xbmc/res/layout/activity_splash.xml | 2 -- 1 file changed, 2 deletions(-) diff --git a/tools/android/packaging/xbmc/res/layout/activity_splash.xml b/tools/android/packaging/xbmc/res/layout/activity_splash.xml index 42e2e29333466..77ba992089ed9 100644 --- a/tools/android/packaging/xbmc/res/layout/activity_splash.xml +++ b/tools/android/packaging/xbmc/res/layout/activity_splash.xml @@ -7,9 +7,7 @@ android:id="@+id/imageView1" android:layout_width="match_parent" android:layout_height="match_parent" - android:layout_centerHorizontal="true" android:adjustViewBounds="true" - android:layout_alignParentTop="true" android:scaleType="centerCrop" android:src="@drawable/applaunch_screen" /> From 2423ed670e15ed5d4bb3d8c5d59ff81b9b4b8665 Mon Sep 17 00:00:00 2001 From: Jose Luis Marti Date: Tue, 23 Apr 2024 22:50:49 +0200 Subject: [PATCH 2/4] Use start/end instead of left/right attributes --- tools/android/packaging/xbmc/res/layout/activity_splash.xml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/android/packaging/xbmc/res/layout/activity_splash.xml b/tools/android/packaging/xbmc/res/layout/activity_splash.xml index 77ba992089ed9..626443e2a7120 100644 --- a/tools/android/packaging/xbmc/res/layout/activity_splash.xml +++ b/tools/android/packaging/xbmc/res/layout/activity_splash.xml @@ -21,8 +21,8 @@ style="?android:attr/progressBarStyleHorizontal" android:layout_width="wrap_content" android:layout_height="wrap_content" - android:layout_alignParentLeft="true" - android:layout_alignParentRight="true" + android:layout_alignParentStart="true" + android:layout_alignParentEnd="true" android:layout_alignParentBottom="true" android:layout_centerHorizontal="true" android:layout_marginLeft="20dp" From 9d60828c60e0f6fb580d5e04dc01ce1700d9be07 Mon Sep 17 00:00:00 2001 From: Jose Luis Marti Date: Tue, 23 Apr 2024 22:52:55 +0200 Subject: [PATCH 3/4] Use sp instead of dp for text sizes --- tools/android/packaging/xbmc/res/layout/activity_splash.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/android/packaging/xbmc/res/layout/activity_splash.xml b/tools/android/packaging/xbmc/res/layout/activity_splash.xml index 626443e2a7120..bb952ca8d4de8 100644 --- a/tools/android/packaging/xbmc/res/layout/activity_splash.xml +++ b/tools/android/packaging/xbmc/res/layout/activity_splash.xml @@ -39,7 +39,7 @@ android:layout_centerHorizontal="true" android:text="" android:textColor="@android:color/white" - android:textSize="16dp" /> + android:textSize="16sp" /> From 8d8f636f9b5880d17fb8f68be91187de58160037 Mon Sep 17 00:00:00 2001 From: Jose Luis Marti Date: Tue, 23 Apr 2024 22:55:02 +0200 Subject: [PATCH 4/4] Add contentDescription to image --- tools/android/packaging/xbmc/res/layout/activity_splash.xml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tools/android/packaging/xbmc/res/layout/activity_splash.xml b/tools/android/packaging/xbmc/res/layout/activity_splash.xml index bb952ca8d4de8..39c2b6e30edc3 100644 --- a/tools/android/packaging/xbmc/res/layout/activity_splash.xml +++ b/tools/android/packaging/xbmc/res/layout/activity_splash.xml @@ -9,7 +9,8 @@ android:layout_height="match_parent" android:adjustViewBounds="true" android:scaleType="centerCrop" - android:src="@drawable/applaunch_screen" /> + android:src="@drawable/applaunch_screen" + android:contentDescription="@string/app_name" />