Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add routes, basic logic on Home #31

Open
wants to merge 4 commits into
base: master
from

Conversation

Projects
None yet
3 participants
@pynnl
Copy link

commented Nov 16, 2018

Fixes #26

qxegsvijct

Changes:

  • Add 2 main routes for core features: /, /story
  • Add basic logic on route /, including list stories, create story, and join story.
  • Move logic in app.js to proper route
  • Add config.js for general data like PORT or SERVER, make it easier to reconfigure on production.

Notes:

  • The choice of names (game, playerID,...) is based on boardgame.io's names to not cause confusion through out codes. The terminology such as story, writer will only be shown to end users.
  • The process of finding an available slot to join a game is currently not supported by the server api, so we have to loop the requests from the client til found one (check joinGameRequest()). This logic can be change once boardgame.io upgrades their api.

Todo:

  • After a successful join request, we get the playerCredentials. Next step is to navigate to /story after users click join, with the playerCredentials and other game info.
  • Logic on route /story

@SeanPrashad SeanPrashad self-requested a review Nov 16, 2018

@pynnl pynnl force-pushed the pynnl:issue-26 branch from 46e310d to a4ea166 Nov 17, 2018

@SeanPrashad

This comment has been minimized.

Copy link
Contributor

commented Nov 17, 2018

Thanks for rebasing @pynnl - this is still on our radar for a review soon

@klymenkoo
Copy link
Collaborator

left a comment

@pynnl thanks for the contribution! You did a great job.
Your PR looks good to me. Let's wait for @SeanPrashad and @Mera-Gangapersaud review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.