New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken example of how to create dynamic collections #2032

Closed
SteveEdson opened this Issue Oct 4, 2017 · 2 comments

Comments

2 participants
@SteveEdson
Contributor

SteveEdson commented Oct 4, 2017

I'm trying to create a dynamic sales collection of all invoices which contain a line item with a specific sku. The docs at https://merchello.readme.io/docs/sales-collections provide an example of how to do this

Below is the code for the Unpaid Invoices dynamic collection, which you can use as a reference to create your own

However, the important part:

var query = Query<IInvoice>.Builder.Where(x => x.InvoiceStatusKey == Constants.DefaultKeys.InvoiceStatus.Unpaid);

return _invoiceService.GetPagedKeys(query, page, itemsPerPage, sortBy, sortDirection);

Isn't possible, as _invoiceService.GetPagedKeys is an internal method. Can this be changed to public / is there a way around this?

Thanks.

@YodasMyDad

This comment has been minimized.

Show comment
Hide comment
@YodasMyDad

YodasMyDad Oct 12, 2017

Contributor

Ah. I'll speak with Rusty but I don't see why that is internal.

Contributor

YodasMyDad commented Oct 12, 2017

Ah. I'll speak with Rusty but I don't see why that is internal.

@YodasMyDad YodasMyDad added the bug label Oct 12, 2017

@YodasMyDad YodasMyDad self-assigned this Oct 13, 2017

@YodasMyDad YodasMyDad added this to To Do in Merchello 2.7.0 Oct 13, 2017

@YodasMyDad YodasMyDad moved this from To Do to Coding in Merchello 2.7.0 Nov 4, 2017

@YodasMyDad YodasMyDad moved this from Coding to Done in Merchello 2.7.0 Nov 4, 2017

@YodasMyDad YodasMyDad closed this in #2089 Nov 4, 2017

@SteveEdson

This comment has been minimized.

Show comment
Hide comment
@SteveEdson

SteveEdson Nov 4, 2017

Contributor

Awesome, thanks!

Contributor

SteveEdson commented Nov 4, 2017

Awesome, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment