New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix on "Product Extended Content disappearing when switching between tabs" #2194

Open
joecklau opened this Issue Nov 15, 2018 · 2 comments

Comments

Projects
None yet
2 participants
@joecklau

joecklau commented Nov 15, 2018

For the thread Product Extended Content disappearing when switching between tabs, the community (including me) found problem when switching product tabs.

I added my fix in as thread comment, but I haven't make it pull-request because it's only fixing the radio button but not checkbox. Actually I think my fix is just a fix AFTER the error is produced somewhere, while the true fix (fix at the error source) should happen somewhere else. But I'm not that familiar with the merchello js code... wish the js author can help

@YodasMyDad

This comment has been minimized.

Contributor

YodasMyDad commented Nov 15, 2018

I will try and replicate this today. But it is not something that I have had an issue with or ever seen and I have a few sites on 2.7.0 with a ton of extended content including checkboxes.

@joecklau

This comment has been minimized.

joecklau commented Nov 15, 2018

First time tab-switching will work as normal, but after several switching between the extended content tab will re-produce the problem.
Given that each radio button should have value=ID(eg 152,83,93,...), after several tab switching, you will see the value of the radio button become simply ordering number (0,1,2,...) instead of ID, so saving at this moment will destroy the record.
Use chrome F12 will see the change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment