Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extrapolate payment providers into separate Nuget packages #2239

Open
benjaminhowarth1 opened this issue Mar 12, 2019 · 0 comments

Comments

2 participants
@benjaminhowarth1
Copy link
Collaborator

commented Mar 12, 2019

Currently looking at updating the community-provided Stripe provider to support Merchello 2.0+, and Merchello.Core has a dependency on the PayPal SDK.

This seems... horrible.

Will open a fork & send in PRs.

benjaminhowarth1 added a commit to benjaminhowarth1/Merchello that referenced this issue Apr 3, 2019

Merchello#2239 relocated Paypal into separate project. Had to make a …
…couple of internal extensions & attributes public along the way, but now Paypal module is the only module that has a hard dependency on the Paypal Nuget SDKs, meaning creating a Stripe provider based on this build should now work without a redundant Nuget dependency.

benjaminhowarth1 added a commit to benjaminhowarth1/Merchello that referenced this issue Apr 5, 2019

Merchello#2239 Moved Braintree & Paypal providers to their own projec…
…ts & set up appropriate Nuspecs.

Also had to update StringExtensions namespace aliasing to avoid conflict.

@benjaminhowarth1 benjaminhowarth1 self-assigned this Apr 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.