Virtual products #2182
Open
Virtual products #2182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…efore it was made virtual
…f services, needs some caching
fixed migration for virtual products column
fixed saving virtual variants flag on a product
Virtual products
|
Thanks for doing this. I'll leave this open for now. As I think it's an edge case. |
|
Understand however the PR does not change default functionality. It just adds an alternate/lazy method of generating variants so is worth considering. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure if you want to merge this but it is our working "virtual products" development.
It allows product variants to be generated on the fly rather than database stored as currently - its backward compatible as there is a tick box per product to enable.
Its main use is as we discussed a long time ago around the performance of the admin area once the product option count is high.
We added some helpers in to allow for products to be created on the fly for adding to basket etc. Let me know if you want to go through anything or if merging is not something you wish to do.