Fix assignment of attribute uninteger_is_from by to_integer()
#591
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up to my big refactor of the S3 classes in #584. I missed the use of
class(x)at the end ofto_integer()to assign the attributeuninteger_is_from. This caused the wrong value ofuninteger_is_fromto be assigned because the method is no longer embedded in the class hierarchy.gsDesign2/R/to_integer.R
Lines 579 to 592 in 5103d9c
While writing a test for this, I discovered that
to_integer()is unable to process the object returned bygs_power_rd()because it doesn't have the elementinputwith the values of its input arguments. I went ahead and fixed that too.