Play a sound when you receive a tell #341
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This plays a pre-existing wav (that is not used in the game as far as I know) whenever the user receives a tell. This is a much needed feature for those who are AFK, looking at other windows, and so on. Definitely open to other sounds. This one is the most appropriate I could find.
MorbusM59
pushed a commit
to MorbusM59/Meridian59
that referenced
this pull request
Jan 31, 2017
Adding new passive objects / corrections
|
@Meridian59 Do you care for this type of feature? If open to it, is it safe to assume something like this also needs to include an option under Preferences? |
|
I've never heard anyone ask for it. It would definitely have to come with a client setting to turn it off. Actually, this should probably be done completely client-side. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This plays a pre-existing wav (that is not used in the game as far as I
know) whenever the user receives a tell. This is a much needed feature
for those who are AFK, looking at other windows, and so on.
Definitely open to using other sounds. This one is the most appropriate I
could find within existing resources.