Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Two small fixes for swagger2openapi's x-ms-parameterized-host conversion #160

Merged
merged 2 commits into from Apr 17, 2019

Conversation

Projects
None yet
2 participants
@pimterry
Copy link
Contributor

pimterry commented Apr 2, 2019

Right now, the generated server URLs are missing two things:

  • The protocol scheme (except where useSchemePrefix is set to false)
  • The base path

As an example, compare the Azure Vision v1 spec with the URLs from the Vision v1 docs.

The docs use URLs like https://[location].api.cognitive.microsoft.com/vision/v1.0/analyze.

Converting the specs with swagger2openapi at the moment though gives a server URL of just {AzureRegion}.api.cognitive.microsoft.com, followed by paths like /analyze. See https://unpkg.com/openapi-directory@1.0.1/api/azure.com/cognitiveservices-ComputerVision.json for an example converted with the current codebase.

@MikeRalphson MikeRalphson merged commit 8d11cc2 into Mermade:master Apr 17, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@MikeRalphson

This comment has been minimized.

Copy link
Contributor

MikeRalphson commented Apr 17, 2019

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.