feat(account-api): add missing {align,discover}Accounts
#368
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ccharly
changed the title
{align,discover}Accounts
ccharly
force-pushed
the
feat/re-align-api
branch
from
7f8e00d to
9e33660
Compare
ccharly
force-pushed
the
feat/re-align-api
branch
from
9e33660 to
d5d6da0
Compare
ccharly
commented
Sep 10, 2025
ccharly
commented
Sep 10, 2025
danroc
approved these changes
Sep 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Those methods were already implemented in the
multichain-account-service. We now add them at API level so we can rely on the API typeMultichainAccountWalletto execute those operations.Note
The name are also different now, to emphasis more on the actual operations being run on on the "blockchain accounts" themselves:
<operation>Accounts