Update approval controller test import #339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The approval controller tests were importing the _built_ version of the approval controller, rather than the original source. This resulted in odd coverage stats, and necessitated ignoring `dist/BaseController*`. By updating the import to use the source directly, the coverage stats look fine without ignoring anything.
rickycodes
approved these changes
Feb 11, 2021
rickycodes
added a commit
that referenced
this pull request
Feb 18, 2021
…ba into feature/migrate-to-etherscan * 'feature/migrate-to-etherscan' of github.com:MetaMask/gaba: Update `sinon` and `@types/sinon` to latest versions (#352) Fix `tsconfig.json` indentation (#355) Replace `fetch-mock` with `nock` (#340) Update `ethereumjs-wallet` from v0.6.5 to v1.0.1 (#347) Add `babel-runtime` dependency required by `ethjs-query` (#341) Update `@metamask/eslint-config` from v3 to v4.1.0 (#344) Add `docs` to list of ignored eslint patterns (#345) Update `uuid` from `v3.3.3` to `v8.3.2` (#346) Update approval controller test import (#339) Add Dependabot config (#343) Update `typedoc` (#342) Remove unused test module (#338) Replace `await-semaphore` with `async-mutex` (#334) Update `eth-json-rpc-filters` in lockfile (#336)
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
The approval controller tests were importing the _built_ version of the approval controller, rather than the original source. This resulted in odd coverage stats, and necessitated ignoring `dist/BaseController*`. By updating the import to use the source directly, the coverage stats look fine without ignoring anything.
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
The approval controller tests were importing the _built_ version of the approval controller, rather than the original source. This resulted in odd coverage stats, and necessitated ignoring `dist/BaseController*`. By updating the import to use the source directly, the coverage stats look fine without ignoring anything.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The approval controller tests were importing the built version of the approval controller, rather than the original source. This resulted in odd coverage stats, and necessitated ignoring
dist/BaseController*.By updating the import to use the source directly, the coverage stats look fine without ignoring anything.