diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS index cde60de05ab..5a4287720dd 100644 --- a/.github/CODEOWNERS +++ b/.github/CODEOWNERS @@ -4,175 +4,186 @@ # Note: Please keep this synchronized with the `teams.json` file in the repository root. # That file is used for some automated workflows, and maps controller to owning team(s). -/.github/ @MetaMask/core-platform - -## Accounts Team -/packages/accounts-controller @MetaMask/accounts-engineers -/packages/multichain-transactions-controller @MetaMask/accounts-engineers -/packages/multichain-account-service @MetaMask/accounts-engineers -/packages/account-tree-controller @MetaMask/accounts-engineers -/packages/profile-sync-controller @MetaMask/accounts-engineers - -## Assets Team -/packages/assets-controllers @MetaMask/metamask-assets -/packages/network-enablement-controller @MetaMask/metamask-assets - -## Confirmations Team -/packages/address-book-controller @MetaMask/confirmations -/packages/approval-controller @MetaMask/confirmations -/packages/ens-controller @MetaMask/confirmations -/packages/gas-fee-controller @MetaMask/confirmations -/packages/logging-controller @MetaMask/confirmations -/packages/message-manager @MetaMask/confirmations -/packages/name-controller @MetaMask/confirmations -/packages/signature-controller @MetaMask/confirmations -/packages/transaction-controller @MetaMask/confirmations -/packages/user-operation-controller @MetaMask/confirmations - -## Delegation Team -/packages/gator-permissions-controller @MetaMask/delegation -/packages/eip-7702-internal-rpc-middleware @MetaMask/delegation @MetaMask/core-platform - -## Earn Team -/packages/earn-controller @MetaMask/earn - -## Notifications Team -/packages/notification-services-controller @MetaMask/notifications - -## Product Safety Team -/packages/phishing-controller @MetaMask/product-safety - -## Swaps-Bridge Team -/packages/bridge-controller @MetaMask/swaps-engineers -/packages/bridge-status-controller @MetaMask/swaps-engineers - -## Mobile Platform Team -/packages/app-metadata-controller @MetaMask/mobile-platform - -## Portfolio Team -/packages/token-search-discovery-controller @MetaMask/portfolio - -## Vault Team -/packages/delegation-controller @MetaMask/vault - -## Wallet Integrations Team -/packages/chain-agnostic-permission @MetaMask/wallet-integrations -/packages/eip1193-permission-middleware @MetaMask/wallet-integrations -/packages/multichain-api-middleware @MetaMask/wallet-integrations -/packages/selected-network-controller @MetaMask/wallet-integrations -/packages/eip-5792-middleware @MetaMask/wallet-integrations - -## Core Platform Team -/packages/base-controller @MetaMask/core-platform -/packages/build-utils @MetaMask/core-platform -/packages/composable-controller @MetaMask/core-platform -/packages/controller-utils @MetaMask/core-platform -/packages/error-reporting-service @MetaMask/core-platform -/packages/eth-json-rpc-middleware @MetaMask/core-platform -/packages/messenger @MetaMask/core-platform -/packages/sample-controllers @MetaMask/core-platform -/packages/polling-controller @MetaMask/core-platform -/packages/preferences-controller @MetaMask/core-platform -/packages/rate-limit-controller @MetaMask/core-platform - -## Web3Auth Team -/packages/seedless-onboarding-controller @MetaMask/web3auth -/packages/shield-controller @MetaMask/web3auth -/packages/subscription-controller @MetaMask/web3auth - -## Joint team ownership -/packages/announcement-controller @MetaMask/core-extension-ux @MetaMask/mobile-core-ux -/packages/core-backend @MetaMask/core-platform @MetaMask/metamask-assets -/packages/eth-block-tracker @MetaMask/wallet-integrations @MetaMask/core-platform -/packages/eth-json-rpc-middleware/src/methods @MetaMask/confirmations @MetaMask/wallet-api-platform-engineers -/packages/eth-json-rpc-middleware/src/wallet.* @MetaMask/confirmations @MetaMask/wallet-api-platform-engineers -/packages/eth-json-rpc-provider @MetaMask/wallet-integrations @MetaMask/core-platform -/packages/foundryup @MetaMask/mobile-platform @MetaMask/extension-platform -/packages/json-rpc-engine @MetaMask/wallet-integrations @MetaMask/core-platform -/packages/json-rpc-middleware-stream @MetaMask/wallet-integrations @MetaMask/core-platform -/packages/keyring-controller @MetaMask/accounts-engineers @MetaMask/core-platform -/packages/multichain-network-controller @MetaMask/core-platform @MetaMask/accounts-engineers @MetaMask/metamask-assets -/packages/network-controller @MetaMask/core-platform @MetaMask/metamask-assets -/packages/permission-controller @MetaMask/wallet-integrations @MetaMask/core-platform -/packages/permission-log-controller @MetaMask/wallet-integrations @MetaMask/core-platform -/packages/remote-feature-flag-controller @MetaMask/extension-platform @MetaMask/mobile-platform @MetaMask/core-platform - -## Package Release related -/packages/account-tree-controller/package.json @MetaMask/accounts-engineers @MetaMask/core-platform -/packages/account-tree-controller/CHANGELOG.md @MetaMask/accounts-engineers @MetaMask/core-platform -/packages/accounts-controller/package.json @MetaMask/accounts-engineers @MetaMask/core-platform -/packages/accounts-controller/CHANGELOG.md @MetaMask/accounts-engineers @MetaMask/core-platform -/packages/address-book-controller/package.json @MetaMask/confirmations @MetaMask/core-platform -/packages/address-book-controller/CHANGELOG.md @MetaMask/confirmations @MetaMask/core-platform -/packages/announcement-controller/package.json @MetaMask/core-extension-ux @MetaMask/mobile-core-ux @MetaMask/core-platform -/packages/announcement-controller/CHANGELOG.md @MetaMask/core-extension-ux @MetaMask/mobile-core-ux @MetaMask/core-platform -/packages/approval-controller/package.json @MetaMask/confirmations @MetaMask/core-platform -/packages/approval-controller/CHANGELOG.md @MetaMask/confirmations @MetaMask/core-platform -/packages/assets-controllers/package.json @MetaMask/metamask-assets @MetaMask/core-platform -/packages/assets-controllers/CHANGELOG.md @MetaMask/metamask-assets @MetaMask/core-platform -/packages/chain-agnostic-permission/package.json @MetaMask/wallet-integrations @MetaMask/core-platform -/packages/chain-agnostic-permission/CHANGELOG.md @MetaMask/wallet-integrations @MetaMask/core-platform -/packages/delegation-controller/package.json @MetaMask/vault @MetaMask/core-platform -/packages/delegation-controller/CHANGELOG.md @MetaMask/vault @MetaMask/core-platform -/packages/earn-controller/package.json @MetaMask/earn @MetaMask/core-platform -/packages/earn-controller/CHANGELOG.md @MetaMask/earn @MetaMask/core-platform -/packages/eip-5792-middleware/package.json @MetaMask/wallet-integrations @MetaMask/core-platform -/packages/eip-5792-middleware/CHANGELOG.md @MetaMask/wallet-integrations @MetaMask/core-platform -/packages/eip1193-permission-middleware/package.json @MetaMask/wallet-integrations @MetaMask/core-platform -/packages/eip1193-permission-middleware/CHANGELOG.md @MetaMask/wallet-integrations @MetaMask/core-platform -/packages/ens-controller/package.json @MetaMask/confirmations @MetaMask/core-platform -/packages/ens-controller/CHANGELOG.md @MetaMask/confirmations @MetaMask/core-platform -/packages/gas-fee-controller/package.json @MetaMask/confirmations @MetaMask/core-platform -/packages/gas-fee-controller/CHANGELOG.md @MetaMask/confirmations @MetaMask/core-platform -/packages/gator-permissions-controller/package.json @MetaMask/delegation @MetaMask/core-platform -/packages/gator-permissions-controller/CHANGELOG.md @MetaMask/delegation @MetaMask/core-platform -/packages/keyring-controller/package.json @MetaMask/accounts-engineers @MetaMask/core-platform -/packages/keyring-controller/CHANGELOG.md @MetaMask/accounts-engineers @MetaMask/core-platform -/packages/logging-controller/package.json @MetaMask/confirmations @MetaMask/core-platform -/packages/logging-controller/CHANGELOG.md @MetaMask/confirmations @MetaMask/core-platform -/packages/message-manager/package.json @MetaMask/confirmations @MetaMask/core-platform -/packages/message-manager/CHANGELOG.md @MetaMask/confirmations @MetaMask/core-platform -/packages/multichain-account-service/package.json @MetaMask/accounts-engineers @MetaMask/core-platform -/packages/multichain-account-service/CHANGELOG.md @MetaMask/accounts-engineers @MetaMask/core-platform -/packages/multichain-api-middleware/package.json @MetaMask/wallet-integrations @MetaMask/core-platform -/packages/multichain-api-middleware/CHANGELOG.md @MetaMask/wallet-integrations @MetaMask/core-platform -/packages/name-controller/package.json @MetaMask/confirmations @MetaMask/core-platform -/packages/name-controller/CHANGELOG.md @MetaMask/confirmations @MetaMask/core-platform -/packages/notification-services-controller/package.json @MetaMask/notifications @MetaMask/core-platform -/packages/notification-services-controller/CHANGELOG.md @MetaMask/notifications @MetaMask/core-platform -/packages/phishing-controller/package.json @MetaMask/product-safety @MetaMask/core-platform -/packages/phishing-controller/CHANGELOG.md @MetaMask/product-safety @MetaMask/core-platform -/packages/profile-sync-controller/package.json @MetaMask/accounts-engineers @MetaMask/core-platform -/packages/profile-sync-controller/CHANGELOG.md @MetaMask/accounts-engineers @MetaMask/core-platform -/packages/selected-network-controller/package.json @MetaMask/wallet-integrations @MetaMask/core-platform -/packages/selected-network-controller/CHANGELOG.md @MetaMask/wallet-integrations @MetaMask/core-platform -/packages/signature-controller/package.json @MetaMask/confirmations @MetaMask/core-platform -/packages/signature-controller/CHANGELOG.md @MetaMask/confirmations @MetaMask/core-platform -/packages/transaction-controller/package.json @MetaMask/confirmations @MetaMask/core-platform -/packages/transaction-controller/CHANGELOG.md @MetaMask/confirmations @MetaMask/core-platform -/packages/user-operation-controller/package.json @MetaMask/confirmations @MetaMask/core-platform -/packages/user-operation-controller/CHANGELOG.md @MetaMask/confirmations @MetaMask/core-platform -/packages/multichain-transactions-controller/package.json @MetaMask/accounts-engineers @MetaMask/core-platform -/packages/multichain-transactions-controller/CHANGELOG.md @MetaMask/accounts-engineers @MetaMask/core-platform -/packages/token-search-discovery-controller/package.json @MetaMask/portfolio @MetaMask/core-platform -/packages/token-search-discovery-controller/CHANGELOG.md @MetaMask/portfolio @MetaMask/core-platform -/packages/bridge-controller/package.json @MetaMask/swaps-engineers @MetaMask/core-platform -/packages/bridge-controller/CHANGELOG.md @MetaMask/swaps-engineers @MetaMask/core-platform -/packages/remote-feature-flag-controller/package.json @MetaMask/extension-platform @MetaMask/mobile-platform @MetaMask/core-platform -/packages/remote-feature-flag-controller/CHANGELOG.md @MetaMask/extension-platform @MetaMask/mobile-platform @MetaMask/core-platform -/packages/bridge-status-controller/package.json @MetaMask/swaps-engineers @MetaMask/core-platform -/packages/bridge-status-controller/CHANGELOG.md @MetaMask/swaps-engineers @MetaMask/core-platform -/packages/app-metadata-controller/package.json @MetaMask/mobile-platform @MetaMask/core-platform -/packages/app-metadata-controller/CHANGELOG.md @MetaMask/mobile-platform @MetaMask/core-platform -/packages/foundryup/package.json @MetaMask/mobile-platform @MetaMask/extension-platform @MetaMask/core-platform -/packages/foundryup/CHANGELOG.md @MetaMask/mobile-platform @MetaMask/extension-platform @MetaMask/core-platform -/packages/seedless-onboarding-controller/package.json @MetaMask/web3auth @MetaMask/core-platform -/packages/seedless-onboarding-controller/CHANGELOG.md @MetaMask/web3auth @MetaMask/core-platform -/packages/shield-controller/package.json @MetaMask/web3auth @MetaMask/core-platform -/packages/shield-controller/CHANGELOG.md @MetaMask/web3auth @MetaMask/core-platform -/packages/network-enablement-controller/package.json @MetaMask/metamask-assets @MetaMask/core-platform -/packages/network-enablement-controller/CHANGELOG.md @MetaMask/metamask-assets @MetaMask/core-platform -/packages/subscription-controller/package.json @MetaMask/web3auth @MetaMask/core-platform -/packages/subscription-controller/CHANGELOG.md @MetaMask/web3auth @MetaMask/core-platform -/packages/core-backend/package.json @MetaMask/core-platform @MetaMask/metamask-assets -/packages/core-backend/CHANGELOG.md @MetaMask/core-platform @MetaMask/metamask-assets +# ==================================================================== +# TEMPORARY CODE FREEZE - ALL CHANGES REQUIRE CORE-PLATFORM APPROVAL +# ==================================================================== +# During the migration period, only the core-platform team can approve changes. +# This is a temporary measure and will be reverted after migrations are complete. +# ==================================================================== + +# Make core-platform the owner of everything during code freeze +* @MetaMask/core-platform + +# --- ORIGINAL CODEOWNERS RULES COMMENTED OUT DURING CODE FREEZE --- +# /.github/ @MetaMask/core-platform + +# ## Accounts Team +# # /packages/accounts-controller @MetaMask/accounts-engineers +# # /packages/multichain-transactions-controller @MetaMask/accounts-engineers +# # /packages/multichain-account-service @MetaMask/accounts-engineers +# # /packages/account-tree-controller @MetaMask/accounts-engineers +# # /packages/profile-sync-controller @MetaMask/accounts-engineers + +# ## Assets Team +# # /packages/assets-controllers @MetaMask/metamask-assets +# # /packages/network-enablement-controller @MetaMask/metamask-assets + +# ## Confirmations Team +# # /packages/address-book-controller @MetaMask/confirmations +# # /packages/approval-controller @MetaMask/confirmations +# # /packages/ens-controller @MetaMask/confirmations +# # /packages/gas-fee-controller @MetaMask/confirmations +# # /packages/logging-controller @MetaMask/confirmations +# # /packages/message-manager @MetaMask/confirmations +# # /packages/name-controller @MetaMask/confirmations +# # /packages/signature-controller @MetaMask/confirmations +# # /packages/transaction-controller @MetaMask/confirmations +# # /packages/user-operation-controller @MetaMask/confirmations + +# ## Delegation Team +# # /packages/gator-permissions-controller @MetaMask/delegation +# # /packages/eip-7702-internal-rpc-middleware @MetaMask/delegation @MetaMask/core-platform + +# ## Earn Team +# # /packages/earn-controller @MetaMask/earn + +# ## Notifications Team +# # /packages/notification-services-controller @MetaMask/notifications + +# ## Product Safety Team +# # /packages/phishing-controller @MetaMask/product-safety + +# ## Swaps-Bridge Team +# # /packages/bridge-controller @MetaMask/swaps-engineers +# # /packages/bridge-status-controller @MetaMask/swaps-engineers + +# ## Mobile Platform Team +# # /packages/app-metadata-controller @MetaMask/mobile-platform + +# ## Portfolio Team +# # /packages/token-search-discovery-controller @MetaMask/portfolio + +# ## Vault Team +# # /packages/delegation-controller @MetaMask/vault + +# ## Wallet Integrations Team +# # /packages/chain-agnostic-permission @MetaMask/wallet-integrations +# # /packages/eip1193-permission-middleware @MetaMask/wallet-integrations +# # /packages/multichain-api-middleware @MetaMask/wallet-integrations +# # /packages/selected-network-controller @MetaMask/wallet-integrations +# # /packages/eip-5792-middleware @MetaMask/wallet-integrations + +# ## Core Platform Team +# # /packages/base-controller @MetaMask/core-platform +# # /packages/build-utils @MetaMask/core-platform +# # /packages/composable-controller @MetaMask/core-platform +# # /packages/controller-utils @MetaMask/core-platform +# # /packages/error-reporting-service @MetaMask/core-platform +# # /packages/eth-json-rpc-middleware @MetaMask/core-platform +# # /packages/messenger @MetaMask/core-platform +# # /packages/sample-controllers @MetaMask/core-platform +# # /packages/polling-controller @MetaMask/core-platform +# # /packages/preferences-controller @MetaMask/core-platform +# # /packages/rate-limit-controller @MetaMask/core-platform + +# ## Web3Auth Team +# # /packages/seedless-onboarding-controller @MetaMask/web3auth +# # /packages/shield-controller @MetaMask/web3auth +# # /packages/subscription-controller @MetaMask/web3auth + +# ## Joint team ownership +# /packages/announcement-controller @MetaMask/core-extension-ux @MetaMask/mobile-core-ux +# /packages/core-backend @MetaMask/core-platform @MetaMask/metamask-assets +# /packages/eth-block-tracker @MetaMask/wallet-integrations @MetaMask/core-platform +# /packages/eth-json-rpc-middleware/src/methods @MetaMask/confirmations @MetaMask/wallet-api-platform-engineers +# /packages/eth-json-rpc-middleware/src/wallet.* @MetaMask/confirmations @MetaMask/wallet-api-platform-engineers +# /packages/eth-json-rpc-provider @MetaMask/wallet-integrations @MetaMask/core-platform +# /packages/foundryup @MetaMask/mobile-platform @MetaMask/extension-platform +# /packages/json-rpc-engine @MetaMask/wallet-integrations @MetaMask/core-platform +# /packages/json-rpc-middleware-stream @MetaMask/wallet-integrations @MetaMask/core-platform +# /packages/keyring-controller @MetaMask/accounts-engineers @MetaMask/core-platform +# /packages/multichain-network-controller @MetaMask/core-platform @MetaMask/accounts-engineers @MetaMask/metamask-assets +# /packages/network-controller @MetaMask/core-platform @MetaMask/metamask-assets +# /packages/permission-controller @MetaMask/wallet-integrations @MetaMask/core-platform +# /packages/permission-log-controller @MetaMask/wallet-integrations @MetaMask/core-platform +# /packages/remote-feature-flag-controller @MetaMask/extension-platform @MetaMask/mobile-platform @MetaMask/core-platform + +# ## Package Release related +# /packages/account-tree-controller/package.json @MetaMask/accounts-engineers @MetaMask/core-platform +# /packages/account-tree-controller/CHANGELOG.md @MetaMask/accounts-engineers @MetaMask/core-platform +# /packages/accounts-controller/package.json @MetaMask/accounts-engineers @MetaMask/core-platform +# /packages/accounts-controller/CHANGELOG.md @MetaMask/accounts-engineers @MetaMask/core-platform +# /packages/address-book-controller/package.json @MetaMask/confirmations @MetaMask/core-platform +# /packages/address-book-controller/CHANGELOG.md @MetaMask/confirmations @MetaMask/core-platform +# /packages/announcement-controller/package.json @MetaMask/core-extension-ux @MetaMask/mobile-core-ux @MetaMask/core-platform +# /packages/announcement-controller/CHANGELOG.md @MetaMask/core-extension-ux @MetaMask/mobile-core-ux @MetaMask/core-platform +# /packages/approval-controller/package.json @MetaMask/confirmations @MetaMask/core-platform +# /packages/approval-controller/CHANGELOG.md @MetaMask/confirmations @MetaMask/core-platform +# /packages/assets-controllers/package.json @MetaMask/metamask-assets @MetaMask/core-platform +# /packages/assets-controllers/CHANGELOG.md @MetaMask/metamask-assets @MetaMask/core-platform +# /packages/chain-agnostic-permission/package.json @MetaMask/wallet-integrations @MetaMask/core-platform +# /packages/chain-agnostic-permission/CHANGELOG.md @MetaMask/wallet-integrations @MetaMask/core-platform +# /packages/delegation-controller/package.json @MetaMask/vault @MetaMask/core-platform +# /packages/delegation-controller/CHANGELOG.md @MetaMask/vault @MetaMask/core-platform +# /packages/earn-controller/package.json @MetaMask/earn @MetaMask/core-platform +# /packages/earn-controller/CHANGELOG.md @MetaMask/earn @MetaMask/core-platform +# /packages/eip-5792-middleware/package.json @MetaMask/wallet-integrations @MetaMask/core-platform +# /packages/eip-5792-middleware/CHANGELOG.md @MetaMask/wallet-integrations @MetaMask/core-platform +# /packages/eip1193-permission-middleware/package.json @MetaMask/wallet-integrations @MetaMask/core-platform +# /packages/eip1193-permission-middleware/CHANGELOG.md @MetaMask/wallet-integrations @MetaMask/core-platform +# /packages/ens-controller/package.json @MetaMask/confirmations @MetaMask/core-platform +# /packages/ens-controller/CHANGELOG.md @MetaMask/confirmations @MetaMask/core-platform +# /packages/gas-fee-controller/package.json @MetaMask/confirmations @MetaMask/core-platform +# /packages/gas-fee-controller/CHANGELOG.md @MetaMask/confirmations @MetaMask/core-platform +# /packages/gator-permissions-controller/package.json @MetaMask/delegation @MetaMask/core-platform +# /packages/gator-permissions-controller/CHANGELOG.md @MetaMask/delegation @MetaMask/core-platform +# /packages/keyring-controller/package.json @MetaMask/accounts-engineers @MetaMask/core-platform +# /packages/keyring-controller/CHANGELOG.md @MetaMask/accounts-engineers @MetaMask/core-platform +# /packages/logging-controller/package.json @MetaMask/confirmations @MetaMask/core-platform +# /packages/logging-controller/CHANGELOG.md @MetaMask/confirmations @MetaMask/core-platform +# /packages/message-manager/package.json @MetaMask/confirmations @MetaMask/core-platform +# /packages/message-manager/CHANGELOG.md @MetaMask/confirmations @MetaMask/core-platform +# /packages/multichain-account-service/package.json @MetaMask/accounts-engineers @MetaMask/core-platform +# /packages/multichain-account-service/CHANGELOG.md @MetaMask/accounts-engineers @MetaMask/core-platform +# /packages/multichain-api-middleware/package.json @MetaMask/wallet-integrations @MetaMask/core-platform +# /packages/multichain-api-middleware/CHANGELOG.md @MetaMask/wallet-integrations @MetaMask/core-platform +# /packages/name-controller/package.json @MetaMask/confirmations @MetaMask/core-platform +# /packages/name-controller/CHANGELOG.md @MetaMask/confirmations @MetaMask/core-platform +# /packages/notification-services-controller/package.json @MetaMask/notifications @MetaMask/core-platform +# /packages/notification-services-controller/CHANGELOG.md @MetaMask/notifications @MetaMask/core-platform +# /packages/phishing-controller/package.json @MetaMask/product-safety @MetaMask/core-platform +# /packages/phishing-controller/CHANGELOG.md @MetaMask/product-safety @MetaMask/core-platform +# /packages/profile-sync-controller/package.json @MetaMask/accounts-engineers @MetaMask/core-platform +# /packages/profile-sync-controller/CHANGELOG.md @MetaMask/accounts-engineers @MetaMask/core-platform +# /packages/selected-network-controller/package.json @MetaMask/wallet-integrations @MetaMask/core-platform +# /packages/selected-network-controller/CHANGELOG.md @MetaMask/wallet-integrations @MetaMask/core-platform +# /packages/signature-controller/package.json @MetaMask/confirmations @MetaMask/core-platform +# /packages/signature-controller/CHANGELOG.md @MetaMask/confirmations @MetaMask/core-platform +# /packages/transaction-controller/package.json @MetaMask/confirmations @MetaMask/core-platform +# /packages/transaction-controller/CHANGELOG.md @MetaMask/confirmations @MetaMask/core-platform +# /packages/user-operation-controller/package.json @MetaMask/confirmations @MetaMask/core-platform +# /packages/user-operation-controller/CHANGELOG.md @MetaMask/confirmations @MetaMask/core-platform +# /packages/multichain-transactions-controller/package.json @MetaMask/accounts-engineers @MetaMask/core-platform +# /packages/multichain-transactions-controller/CHANGELOG.md @MetaMask/accounts-engineers @MetaMask/core-platform +# /packages/token-search-discovery-controller/package.json @MetaMask/portfolio @MetaMask/core-platform +# /packages/token-search-discovery-controller/CHANGELOG.md @MetaMask/portfolio @MetaMask/core-platform +# /packages/bridge-controller/package.json @MetaMask/swaps-engineers @MetaMask/core-platform +# /packages/bridge-controller/CHANGELOG.md @MetaMask/swaps-engineers @MetaMask/core-platform +# /packages/remote-feature-flag-controller/package.json @MetaMask/extension-platform @MetaMask/mobile-platform @MetaMask/core-platform +# /packages/remote-feature-flag-controller/CHANGELOG.md @MetaMask/extension-platform @MetaMask/mobile-platform @MetaMask/core-platform +# /packages/bridge-status-controller/package.json @MetaMask/swaps-engineers @MetaMask/core-platform +# /packages/bridge-status-controller/CHANGELOG.md @MetaMask/swaps-engineers @MetaMask/core-platform +# /packages/app-metadata-controller/package.json @MetaMask/mobile-platform @MetaMask/core-platform +# /packages/app-metadata-controller/CHANGELOG.md @MetaMask/mobile-platform @MetaMask/core-platform +# /packages/foundryup/package.json @MetaMask/mobile-platform @MetaMask/extension-platform @MetaMask/core-platform +# /packages/foundryup/CHANGELOG.md @MetaMask/mobile-platform @MetaMask/extension-platform @MetaMask/core-platform +# /packages/seedless-onboarding-controller/package.json @MetaMask/web3auth @MetaMask/core-platform +# /packages/seedless-onboarding-controller/CHANGELOG.md @MetaMask/web3auth @MetaMask/core-platform +# /packages/shield-controller/package.json @MetaMask/web3auth @MetaMask/core-platform +# /packages/shield-controller/CHANGELOG.md @MetaMask/web3auth @MetaMask/core-platform +# /packages/network-enablement-controller/package.json @MetaMask/metamask-assets @MetaMask/core-platform +# /packages/network-enablement-controller/CHANGELOG.md @MetaMask/metamask-assets @MetaMask/core-platform +# /packages/subscription-controller/package.json @MetaMask/web3auth @MetaMask/core-platform +# /packages/subscription-controller/CHANGELOG.md @MetaMask/web3auth @MetaMask/core-platform +# /packages/core-backend/package.json @MetaMask/core-platform @MetaMask/metamask-assets +# /packages/core-backend/CHANGELOG.md @MetaMask/core-platform @MetaMask/metamask-assets diff --git a/yarn.config.cjs b/yarn.config.cjs index 8a5002908cd..ba536638f17 100644 --- a/yarn.config.cjs +++ b/yarn.config.cjs @@ -249,7 +249,10 @@ module.exports = defineConfig({ // All non-root packages must have a valid README.md file. await expectReadme(workspace, workspaceBasename); - await expectCodeowner(workspace, workspaceBasename); + // TEMPORARY: Codeowner validation disabled during code freeze + // During the migration period, all packages are owned by core-platform + // through the global * rule in CODEOWNERS file + // await expectCodeowner(workspace, workspaceBasename); } } @@ -861,61 +864,65 @@ async function expectReadme(workspace, workspaceBasename) { } } +// TEMPORARY: cachedCodeownersFile commented out during code freeze // A promise resolving to the codeowners file contents -let cachedCodeownersFile; - -/** - * Expect that the workspace has a codeowner set, and that the CHANGELOG.md and - * package.json files are co-owned with the wallet framework team. - * - * @param {Workspace} workspace - The workspace to check. - * @param {string} workspaceBasename - The name of the workspace. - * @returns {Promise} - */ -async function expectCodeowner(workspace, workspaceBasename) { - if (!cachedCodeownersFile) { - cachedCodeownersFile = readFile( - resolve(__dirname, '.github', 'CODEOWNERS'), - 'utf8', - ); - } - const codeownersFile = await cachedCodeownersFile; - const codeownerRules = codeownersFile.split('\n'); - - const packageCodeownerRule = codeownerRules.find((rule) => - // Matcher includes intentional trailing space to ensure there is a package-wide rule, not - // just a rule for specific files/directories in the package. - rule.startsWith(`/packages/${workspaceBasename} `), - ); - - if (!packageCodeownerRule) { - workspace.error('Missing CODEOWNER rule for package'); - return; - } - - if (!packageCodeownerRule.includes('@MetaMask/core-platform')) { - if ( - !codeownerRules.some( - (rule) => - rule.startsWith(`/packages/${workspaceBasename}/CHANGELOG.md`) && - rule.includes('@MetaMask/core-platform'), - ) - ) { - workspace.error( - 'Missing CODEOWNER rule for CHANGELOG.md co-ownership with core platform team', - ); - } - - if ( - !codeownerRules.some( - (rule) => - rule.startsWith(`/packages/${workspaceBasename}/package.json`) && - rule.includes('@MetaMask/core-platform'), - ) - ) { - workspace.error( - 'Missing CODEOWNER rule for package.json co-ownership with core platform team', - ); - } - } -} +// let cachedCodeownersFile; + +// TEMPORARY: expectCodeowner function commented out during code freeze +// During the migration period, all packages are owned by core-platform +// through the global * rule in CODEOWNERS file +// /** +// * Expect that the workspace has a codeowner set, and that the CHANGELOG.md and +// * package.json files are co-owned with the wallet framework team. +// * +// * @param {Workspace} workspace - The workspace to check. +// * @param {string} workspaceBasename - The name of the workspace. +// * @returns {Promise} +// */ +// async function expectCodeowner(workspace, workspaceBasename) { +// if (!cachedCodeownersFile) { +// cachedCodeownersFile = readFile( +// resolve(__dirname, '.github', 'CODEOWNERS'), +// 'utf8', +// ); +// } +// const codeownersFile = await cachedCodeownersFile; +// const codeownerRules = codeownersFile.split('\n'); +// +// const packageCodeownerRule = codeownerRules.find((rule) => +// // Matcher includes intentional trailing space to ensure there is a package-wide rule, not +// // just a rule for specific files/directories in the package. +// rule.startsWith(`/packages/${workspaceBasename} `), +// ); +// +// if (!packageCodeownerRule) { +// workspace.error('Missing CODEOWNER rule for package'); +// return; +// } +// +// if (!packageCodeownerRule.includes('@MetaMask/core-platform')) { +// if ( +// !codeownerRules.some( +// (rule) => +// rule.startsWith(`/packages/${workspaceBasename}/CHANGELOG.md`) && +// rule.includes('@MetaMask/core-platform'), +// ) +// ) { +// workspace.error( +// 'Missing CODEOWNER rule for CHANGELOG.md co-ownership with core platform team', +// ); +// } +// +// if ( +// !codeownerRules.some( +// (rule) => +// rule.startsWith(`/packages/${workspaceBasename}/package.json`) && +// rule.includes('@MetaMask/core-platform'), +// ) +// ) { +// workspace.error( +// 'Missing CODEOWNER rule for package.json co-ownership with core platform team', +// ); +// } +// } +// }