Skip to content

Conversation

@lwin-kyaw
Copy link
Contributor

@lwin-kyaw lwin-kyaw commented Nov 2, 2025

Explanation

This PR updates SubscriptionControllerState.pricing and updates the submitSponsorshipIntent with chain validation.

References

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've communicated my changes to consumers by updating changelogs for packages I've changed, highlighting breaking changes as necessary
  • I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes

Note

Adds isSponsorshipSupported to crypto pricing chains and updates submitSponsorshipIntents to validate eligibility (chain support + not trialed) and return a boolean.

  • SubscriptionController
    • Sponsorship validation: submitSponsorshipIntents now checks chain support and prior trials, and returns boolean indicating whether intents were submitted.
      • New helpers: #getIsEligibleForTrialedSponsorship(chainId, products) and #getChainSupportsSponsorship(chainId).
    • No functional change to other methods; submitShieldSubscriptionCryptoApproval positioning refactored.
  • Types/State
    • Add pricing.paymentMethods.chains[].isSponsorshipSupported to ChainPaymentInfo and controller state.
  • Tests
    • Update/extend tests to assert non-submission when already trialed or when chain sponsorship is unsupported, and to expect boolean return.
  • Docs/Changelog
    • Update changelog for new field and sponsorship validation.

Written by Cursor Bugbot for commit 397cc2d. This will update automatically on new commits. Configure here.

@lwin-kyaw lwin-kyaw requested a review from a team as a code owner November 2, 2025 23:30
@lwin-kyaw lwin-kyaw requested a review from a team as a code owner November 2, 2025 23:35
@lwin-kyaw
Copy link
Contributor Author

@metamaskbot publish-preview

cursor[bot]

This comment was marked as outdated.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 2, 2025

Preview builds have been published. See these instructions for more information about preview builds.

Expand for full list of packages and versions.
{
  "@metamask-previews/account-tree-controller": "2.0.0-preview-ac95634",
  "@metamask-previews/accounts-controller": "34.0.0-preview-ac95634",
  "@metamask-previews/address-book-controller": "7.0.0-preview-ac95634",
  "@metamask-previews/announcement-controller": "8.0.0-preview-ac95634",
  "@metamask-previews/app-metadata-controller": "2.0.0-preview-ac95634",
  "@metamask-previews/approval-controller": "8.0.0-preview-ac95634",
  "@metamask-previews/assets-controllers": "86.0.0-preview-ac95634",
  "@metamask-previews/base-controller": "9.0.0-preview-ac95634",
  "@metamask-previews/bridge-controller": "58.0.0-preview-ac95634",
  "@metamask-previews/bridge-status-controller": "58.0.0-preview-ac95634",
  "@metamask-previews/build-utils": "3.0.4-preview-ac95634",
  "@metamask-previews/chain-agnostic-permission": "1.2.2-preview-ac95634",
  "@metamask-previews/composable-controller": "12.0.0-preview-ac95634",
  "@metamask-previews/controller-utils": "11.15.0-preview-ac95634",
  "@metamask-previews/core-backend": "4.0.0-preview-ac95634",
  "@metamask-previews/delegation-controller": "1.0.0-preview-ac95634",
  "@metamask-previews/earn-controller": "9.0.0-preview-ac95634",
  "@metamask-previews/eip-5792-middleware": "2.0.0-preview-ac95634",
  "@metamask-previews/eip-7702-internal-rpc-middleware": "0.1.0-preview-ac95634",
  "@metamask-previews/eip1193-permission-middleware": "1.0.2-preview-ac95634",
  "@metamask-previews/ens-controller": "18.0.0-preview-ac95634",
  "@metamask-previews/error-reporting-service": "3.0.0-preview-ac95634",
  "@metamask-previews/eth-block-tracker": "14.0.0-preview-ac95634",
  "@metamask-previews/eth-json-rpc-middleware": "21.0.0-preview-ac95634",
  "@metamask-previews/eth-json-rpc-provider": "5.0.1-preview-ac95634",
  "@metamask-previews/foundryup": "1.0.1-preview-ac95634",
  "@metamask-previews/gas-fee-controller": "25.0.0-preview-ac95634",
  "@metamask-previews/gator-permissions-controller": "0.3.0-preview-ac95634",
  "@metamask-previews/json-rpc-engine": "10.1.1-preview-ac95634",
  "@metamask-previews/json-rpc-middleware-stream": "8.0.8-preview-ac95634",
  "@metamask-previews/keyring-controller": "24.0.0-preview-ac95634",
  "@metamask-previews/logging-controller": "7.0.0-preview-ac95634",
  "@metamask-previews/message-manager": "14.0.0-preview-ac95634",
  "@metamask-previews/messenger": "0.3.0-preview-ac95634",
  "@metamask-previews/multichain-account-service": "2.0.1-preview-ac95634",
  "@metamask-previews/multichain-api-middleware": "1.2.4-preview-ac95634",
  "@metamask-previews/multichain-network-controller": "2.0.0-preview-ac95634",
  "@metamask-previews/multichain-transactions-controller": "6.0.0-preview-ac95634",
  "@metamask-previews/name-controller": "9.0.0-preview-ac95634",
  "@metamask-previews/network-controller": "25.0.0-preview-ac95634",
  "@metamask-previews/network-enablement-controller": "3.1.0-preview-ac95634",
  "@metamask-previews/notification-services-controller": "19.0.0-preview-ac95634",
  "@metamask-previews/permission-controller": "12.1.0-preview-ac95634",
  "@metamask-previews/permission-log-controller": "5.0.0-preview-ac95634",
  "@metamask-previews/phishing-controller": "15.0.0-preview-ac95634",
  "@metamask-previews/polling-controller": "15.0.0-preview-ac95634",
  "@metamask-previews/preferences-controller": "21.0.0-preview-ac95634",
  "@metamask-previews/profile-sync-controller": "26.0.0-preview-ac95634",
  "@metamask-previews/rate-limit-controller": "7.0.0-preview-ac95634",
  "@metamask-previews/remote-feature-flag-controller": "2.0.0-preview-ac95634",
  "@metamask-previews/sample-controllers": "3.0.0-preview-ac95634",
  "@metamask-previews/seedless-onboarding-controller": "6.0.0-preview-ac95634",
  "@metamask-previews/selected-network-controller": "25.0.0-preview-ac95634",
  "@metamask-previews/shield-controller": "1.1.0-preview-ac95634",
  "@metamask-previews/signature-controller": "35.0.0-preview-ac95634",
  "@metamask-previews/subscription-controller": "3.1.0-preview-ac95634",
  "@metamask-previews/token-search-discovery-controller": "4.0.0-preview-ac95634",
  "@metamask-previews/transaction-controller": "61.1.0-preview-ac95634",
  "@metamask-previews/transaction-pay-controller": "2.0.2-preview-ac95634",
  "@metamask-previews/user-operation-controller": "40.0.0-preview-ac95634"
}

tuna1207
tuna1207 previously approved these changes Nov 3, 2025
@chaitanyapotti chaitanyapotti merged commit b9ac734 into main Nov 3, 2025
259 checks passed
@chaitanyapotti chaitanyapotti deleted the feat/sponsored-pricing branch November 3, 2025 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants