Skip to content

Conversation

@V00D00-child
Copy link
Member

@V00D00-child V00D00-child commented Nov 4, 2025

Explanation

Release for @metamask/gator-permissions-controller (0.4.0).

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've communicated my changes to consumers by updating changelogs for packages I've changed, highlighting breaking changes as necessary
  • I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes

Note

Publishes gator-permissions-controller@0.4.0 with breaking state/messenger changes and revocation APIs, and bumps signature-controller to 36.0.0 and shield-controller to 2.0.0 with updated peer deps.

  • Releases:
    • @metamask/gator-permissions-controller@0.4.0 (BREAKING)
      • State now exposes pendingRevocations; add pendingRevocations getter.
      • Require messenger to allow TransactionController:* confirmation/failure/drop events.
      • Add submitRevocation and addPendingRevocation methods (and actions).
      • Add peer dependency on @metamask/transaction-controller.
    • @metamask/signature-controller@36.0.0 (BREAKING)
      • Bump peer dependency on @metamask/gator-permissions-controller to ^0.4.0.
    • @metamask/shield-controller@2.0.0 (BREAKING)
      • Bump (dev/peer) dependency on @metamask/signature-controller to ^36.0.0.
  • Repo:
    • Monorepo version bump to 661.0.0.
    • Lockfile updated for new versions.

Written by Cursor Bugbot for commit 4476880. This will update automatically on new commits. Configure here.

@V00D00-child V00D00-child requested review from a team as code owners November 4, 2025 21:44
mj-kiwi
mj-kiwi previously approved these changes Nov 4, 2025
@V00D00-child V00D00-child enabled auto-merge (squash) November 4, 2025 21:48
hanzel98
hanzel98 previously approved these changes Nov 4, 2025
jeffsmale90
jeffsmale90 previously approved these changes Nov 4, 2025
Copy link
Contributor

@jeffsmale90 jeffsmale90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a couple nits regarding the changelog, but the changelog is sufficiently good to communicate the changes, especially given this is consumed internally only.

Copy link
Contributor

@mcmire mcmire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like there were new actions added to the controller messenger's allowlist (from transaction-controller). These are breaking changes and we need to include them in the changelog.

In fact it looks like transaction-controller was only added as a dev dependency. It must be added as a peer dependency as well. Can you fix this in a separate PR before merging this?

@jeffsmale90 jeffsmale90 dismissed stale reviews from hanzel98, mj-kiwi, and themself via 2ee710c November 4, 2025 23:39
@socket-security
Copy link

socket-security bot commented Nov 4, 2025

No dependency changes detected. Learn more about Socket for GitHub.

👍 No dependency changes detected in pull request

@jeffsmale90
Copy link
Contributor

@SocketSecurity ignore npm/@metamask/signature-controller@35.0.0

Copy link
Contributor

@mcmire mcmire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few more things.

jeffsmale90 and others added 2 commits November 5, 2025 12:49
…oller

Co-authored-by: Elliot Winkler <elliot.winkler@gmail.com>
Co-authored-by: Elliot Winkler <elliot.winkler@gmail.com>
@jeffsmale90 jeffsmale90 requested a review from mcmire November 4, 2025 23:50
Added `@ts-bridge/cli` dependency to resolve failing build

Co-authored-by: Elliot Winkler <elliot.winkler@gmail.com>
mcmire
mcmire previously approved these changes Nov 4, 2025
Copy link
Contributor

@mcmire mcmire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

{
"name": "@metamask/signature-controller",
"version": "35.0.0",
"version": "36.0.0",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Peer dependency gap after signature-controller bump

The signature-controller version is being bumped to 36.0.0, but shield-controller (which has a peer dependency on signature-controller@^35.0.0) is not being updated in this release. This creates an unmet peer dependency issue because the semver range ^35.0.0 does not include version 36.0.0. The shield-controller package needs to be updated to accept signature-controller@^36.0.0 as a peer dependency to maintain compatibility across the monorepo.

Fix in Cursor Fix in Web

hanzel98
hanzel98 previously approved these changes Nov 4, 2025
@jeffsmale90 jeffsmale90 dismissed stale reviews from hanzel98 and mcmire via 87e16bd November 5, 2025 00:08
@jeffsmale90 jeffsmale90 requested a review from a team as a code owner November 5, 2025 00:08

### Changed

- **BREAKING:** Bump `@metamask/signature-controller` from `^35.0.0` to `^36.0.0`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- **BREAKING:** Bump `@metamask/signature-controller` from `^35.0.0` to `^36.0.0`
- **BREAKING:** Bump peer dependency `@metamask/signature-controller` from `^35.0.0` to `^36.0.0` ([#7057](https://github.com/MetaMask/core/pull/7057))

@V00D00-child V00D00-child merged commit a7b83e2 into main Nov 5, 2025
262 checks passed
@V00D00-child V00D00-child deleted the release/661.0.0 branch November 5, 2025 00:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants