-
-
Notifications
You must be signed in to change notification settings - Fork 256
Release/661.0.0 #7057
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release/661.0.0 #7057
Conversation
jeffsmale90
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left a couple nits regarding the changelog, but the changelog is sufficiently good to communicate the changes, especially given this is consumed internally only.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like there were new actions added to the controller messenger's allowlist (from transaction-controller). These are breaking changes and we need to include them in the changelog.
In fact it looks like transaction-controller was only added as a dev dependency. It must be added as a peer dependency as well. Can you fix this in a separate PR before merging this?
2ee710c
2ee710c to
6221487
Compare
|
No dependency changes detected. Learn more about Socket for GitHub. 👍 No dependency changes detected in pull request |
|
@SocketSecurity ignore npm/@metamask/signature-controller@35.0.0 |
mcmire
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few more things.
…oller Co-authored-by: Elliot Winkler <elliot.winkler@gmail.com>
Co-authored-by: Elliot Winkler <elliot.winkler@gmail.com>
Added `@ts-bridge/cli` dependency to resolve failing build Co-authored-by: Elliot Winkler <elliot.winkler@gmail.com>
mcmire
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
| { | ||
| "name": "@metamask/signature-controller", | ||
| "version": "35.0.0", | ||
| "version": "36.0.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Peer dependency gap after signature-controller bump
The signature-controller version is being bumped to 36.0.0, but shield-controller (which has a peer dependency on signature-controller@^35.0.0) is not being updated in this release. This creates an unmet peer dependency issue because the semver range ^35.0.0 does not include version 36.0.0. The shield-controller package needs to be updated to accept signature-controller@^36.0.0 as a peer dependency to maintain compatibility across the monorepo.
|
|
||
| ### Changed | ||
|
|
||
| - **BREAKING:** Bump `@metamask/signature-controller` from `^35.0.0` to `^36.0.0` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| - **BREAKING:** Bump `@metamask/signature-controller` from `^35.0.0` to `^36.0.0` | |
| - **BREAKING:** Bump peer dependency `@metamask/signature-controller` from `^35.0.0` to `^36.0.0` ([#7057](https://github.com/MetaMask/core/pull/7057)) |
Explanation
Release for
@metamask/gator-permissions-controller(0.4.0).Checklist
Note
Publishes
gator-permissions-controller@0.4.0with breaking state/messenger changes and revocation APIs, and bumpssignature-controllerto 36.0.0 andshield-controllerto 2.0.0 with updated peer deps.@metamask/gator-permissions-controller@0.4.0(BREAKING)pendingRevocations; addpendingRevocationsgetter.TransactionController:*confirmation/failure/drop events.submitRevocationandaddPendingRevocationmethods (and actions).@metamask/transaction-controller.@metamask/signature-controller@36.0.0(BREAKING)@metamask/gator-permissions-controllerto^0.4.0.@metamask/shield-controller@2.0.0(BREAKING)@metamask/signature-controllerto^36.0.0.661.0.0.Written by Cursor Bugbot for commit 4476880. This will update automatically on new commits. Configure here.