fix: subscription use bignumber.js for precise crypto approval amount calculation #7070
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
Fix subscription crypto approval amount calculation by using bignumber.js
References
Checklist
Note
Switches subscription price and token approval calculations to bignumber.js for precision; adds dependency and updates changelog.
bignumber.jsinsrc/SubscriptionController.ts:#getSubscriptionPriceAmountnow usesBigNumberfor price computation.getTokenApproveAmountnow usesBigNumberand returnstoFixed(0).bignumber.jstopackages/subscription-controller/package.jsonandyarn.lock.getTokenApproveAmountusingbignumber.jsinCHANGELOG.md.Written by Cursor Bugbot for commit 70df1a3. This will update automatically on new commits. Configure here.