fix: ignore incoming transactions in duplicate nonce check #7097
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
Ignore transactions with
isTransferset when checking for duplicate nonces inPendingTransactionTracker.References
Related to #6135
Checklist
Note
Prevents submitted transactions from being marked as dropped by ignoring confirmed incoming/transfer transactions in the duplicate nonce check, with tests and changelog updated.
#isNonceTakeninsrc/helpers/PendingTransactionTracker.tsto ignore transactions wheretx.type === \incoming`and any withtx.isTransferset, preventing falsedropped` events.src/helpers/PendingTransactionTracker.test.tsto ensure notransaction-droppedevent when nonce matches an incoming/transfer transaction.packages/transaction-controller/CHANGELOG.mdunder "Fixed" to note prevention of falsedroppedstatus for nonce collisions with incoming transactions.Written by Cursor Bugbot for commit 8a1f233. This will update automatically on new commits. Configure here.