Skip to content

Conversation

@tuna1207
Copy link
Member

@tuna1207 tuna1207 commented Nov 12, 2025

Explanation

Subscription controller add useTestClock param to StartSubscriptionRequest, StartCryptoSubscriptionRequest, CachedLastSelectedPaymentMethod

References

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've communicated my changes to consumers by updating changelogs for packages I've changed, highlighting breaking changes as necessary
  • I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes

Note

Adds optional useTestClock to StartSubscriptionRequest, StartCryptoSubscriptionRequest, and CachedLastSelectedPaymentMethod.

  • Types:
    • Add optional useTestClock to StartSubscriptionRequest and StartCryptoSubscriptionRequest in packages/subscription-controller/src/types.ts.
    • Add optional useTestClock to CachedLastSelectedPaymentMethod.
  • Docs:
    • Update packages/subscription-controller/CHANGELOG.md under Unreleased Added section to note new useTestClock params.

Written by Cursor Bugbot for commit f9ec0a8. This will update automatically on new commits. Configure here.

@tuna1207 tuna1207 marked this pull request as ready for review November 12, 2025 10:47
@tuna1207 tuna1207 requested review from a team as code owners November 12, 2025 10:47
@tuna1207
Copy link
Member Author

@metamaskbot publish-preview

@github-actions
Copy link
Contributor

Preview builds have been published. See these instructions for more information about preview builds.

Expand for full list of packages and versions.
{
  "@metamask-previews/account-tree-controller": "3.0.0-preview-f9ec0a8",
  "@metamask-previews/accounts-controller": "34.0.0-preview-f9ec0a8",
  "@metamask-previews/address-book-controller": "7.0.0-preview-f9ec0a8",
  "@metamask-previews/analytics-controller": "0.0.0-preview-f9ec0a8",
  "@metamask-previews/announcement-controller": "8.0.0-preview-f9ec0a8",
  "@metamask-previews/app-metadata-controller": "2.0.0-preview-f9ec0a8",
  "@metamask-previews/approval-controller": "8.0.0-preview-f9ec0a8",
  "@metamask-previews/assets-controllers": "88.0.0-preview-f9ec0a8",
  "@metamask-previews/base-controller": "9.0.0-preview-f9ec0a8",
  "@metamask-previews/bridge-controller": "60.0.0-preview-f9ec0a8",
  "@metamask-previews/bridge-status-controller": "60.0.0-preview-f9ec0a8",
  "@metamask-previews/build-utils": "3.0.4-preview-f9ec0a8",
  "@metamask-previews/chain-agnostic-permission": "1.2.2-preview-f9ec0a8",
  "@metamask-previews/claims-controller": "0.2.0-preview-f9ec0a8",
  "@metamask-previews/composable-controller": "12.0.0-preview-f9ec0a8",
  "@metamask-previews/controller-utils": "11.15.0-preview-f9ec0a8",
  "@metamask-previews/core-backend": "4.0.0-preview-f9ec0a8",
  "@metamask-previews/delegation-controller": "1.0.0-preview-f9ec0a8",
  "@metamask-previews/earn-controller": "10.0.0-preview-f9ec0a8",
  "@metamask-previews/eip-5792-middleware": "2.0.0-preview-f9ec0a8",
  "@metamask-previews/eip-7702-internal-rpc-middleware": "0.1.0-preview-f9ec0a8",
  "@metamask-previews/eip1193-permission-middleware": "1.0.2-preview-f9ec0a8",
  "@metamask-previews/ens-controller": "18.0.0-preview-f9ec0a8",
  "@metamask-previews/error-reporting-service": "3.0.0-preview-f9ec0a8",
  "@metamask-previews/eth-block-tracker": "14.0.0-preview-f9ec0a8",
  "@metamask-previews/eth-json-rpc-middleware": "21.0.0-preview-f9ec0a8",
  "@metamask-previews/eth-json-rpc-provider": "5.0.1-preview-f9ec0a8",
  "@metamask-previews/foundryup": "1.0.1-preview-f9ec0a8",
  "@metamask-previews/gas-fee-controller": "25.0.0-preview-f9ec0a8",
  "@metamask-previews/gator-permissions-controller": "0.4.0-preview-f9ec0a8",
  "@metamask-previews/json-rpc-engine": "10.1.1-preview-f9ec0a8",
  "@metamask-previews/json-rpc-middleware-stream": "8.0.8-preview-f9ec0a8",
  "@metamask-previews/keyring-controller": "24.0.0-preview-f9ec0a8",
  "@metamask-previews/logging-controller": "7.0.0-preview-f9ec0a8",
  "@metamask-previews/message-manager": "14.0.0-preview-f9ec0a8",
  "@metamask-previews/messenger": "0.3.0-preview-f9ec0a8",
  "@metamask-previews/multichain-account-service": "3.0.0-preview-f9ec0a8",
  "@metamask-previews/multichain-api-middleware": "1.2.4-preview-f9ec0a8",
  "@metamask-previews/multichain-network-controller": "2.0.0-preview-f9ec0a8",
  "@metamask-previews/multichain-transactions-controller": "6.0.0-preview-f9ec0a8",
  "@metamask-previews/name-controller": "9.0.0-preview-f9ec0a8",
  "@metamask-previews/network-controller": "25.0.0-preview-f9ec0a8",
  "@metamask-previews/network-enablement-controller": "3.1.0-preview-f9ec0a8",
  "@metamask-previews/notification-services-controller": "19.0.0-preview-f9ec0a8",
  "@metamask-previews/permission-controller": "12.1.0-preview-f9ec0a8",
  "@metamask-previews/permission-log-controller": "5.0.0-preview-f9ec0a8",
  "@metamask-previews/phishing-controller": "15.0.0-preview-f9ec0a8",
  "@metamask-previews/polling-controller": "15.0.0-preview-f9ec0a8",
  "@metamask-previews/preferences-controller": "21.0.0-preview-f9ec0a8",
  "@metamask-previews/profile-sync-controller": "26.0.0-preview-f9ec0a8",
  "@metamask-previews/rate-limit-controller": "7.0.0-preview-f9ec0a8",
  "@metamask-previews/remote-feature-flag-controller": "2.0.0-preview-f9ec0a8",
  "@metamask-previews/sample-controllers": "3.0.0-preview-f9ec0a8",
  "@metamask-previews/seedless-onboarding-controller": "6.1.0-preview-f9ec0a8",
  "@metamask-previews/selected-network-controller": "25.0.0-preview-f9ec0a8",
  "@metamask-previews/shield-controller": "2.0.0-preview-f9ec0a8",
  "@metamask-previews/signature-controller": "36.0.0-preview-f9ec0a8",
  "@metamask-previews/subscription-controller": "4.1.0-preview-f9ec0a8",
  "@metamask-previews/token-search-discovery-controller": "4.0.0-preview-f9ec0a8",
  "@metamask-previews/transaction-controller": "61.2.0-preview-f9ec0a8",
  "@metamask-previews/transaction-pay-controller": "4.0.0-preview-f9ec0a8",
  "@metamask-previews/user-operation-controller": "40.0.0-preview-f9ec0a8"
}

@chaitanyapotti chaitanyapotti merged commit 0ef166f into main Nov 12, 2025
271 checks passed
@chaitanyapotti chaitanyapotti deleted the feat/subscription-use-test-clock branch November 12, 2025 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants