fix: fail required transactions on startup #7251
Merged
+106
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
@metamaskbot publish-preview |
Contributor
|
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
OGPoyraz
approved these changes
Nov 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
During initialisation, the status of all
approvedandsignedtransactions are currently updated tofailed.This PR fails any incomplete required transactions for the above.
Also ensure
isExternalSignis set when retrieving gas fee tokens in messenger action and before publish check, to ensure only EIP-7702 gas fee tokens are used.References
Related to #23348 #23350
Checklist
Note
On init, fail required transactions of approved/signed txs and treat dropped as final; ensure gas fee token fetching sets isExternalSign (including messenger) with tests updated.
requiredTransactionIdsof anyapproved/signedtransactions during initialization.TransactionStatus.droppedas a final state in#isFinalState.TransactionController:getGasFeeTokensnow builds requesttransactionMetawithdelegationAddressandisExternalSign: true.checkGasFeeTokenBeforePublishfetches tokens withisExternalSign: trueand setsisExternalSignon the transaction when applicable.isExternalSignpropagation in gas fee token flows.CHANGELOG.mdto reflect fixes.Written by Cursor Bugbot for commit 77d67b8. This will update automatically on new commits. Configure here.