From e609609cbda80c86a77cf076df94fa29c3d1e51c Mon Sep 17 00:00:00 2001 From: Joao Santos Date: Fri, 24 Apr 2026 12:53:27 +0200 Subject: [PATCH 1/2] chore: add profileId to position response --- packages/social-controllers/src/SocialService.test.ts | 1 + packages/social-controllers/src/SocialService.ts | 1 + packages/social-controllers/src/social-types.ts | 1 + 3 files changed, 3 insertions(+) diff --git a/packages/social-controllers/src/SocialService.test.ts b/packages/social-controllers/src/SocialService.test.ts index 853a4de1333..a9c159ce811 100644 --- a/packages/social-controllers/src/SocialService.test.ts +++ b/packages/social-controllers/src/SocialService.test.ts @@ -38,6 +38,7 @@ const mockTrade = { }; const mockPosition = { + positionId: 'position-1', tokenSymbol: 'ETH', tokenName: 'Ethereum', tokenAddress: '0xeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeee', diff --git a/packages/social-controllers/src/SocialService.ts b/packages/social-controllers/src/SocialService.ts index 380de468a87..02efdfd5a4e 100644 --- a/packages/social-controllers/src/SocialService.ts +++ b/packages/social-controllers/src/SocialService.ts @@ -58,6 +58,7 @@ const ProfileSummaryStruct = structType({ }); const PositionStruct = structType({ + positionId: string(), tokenSymbol: string(), tokenName: string(), tokenAddress: string(), diff --git a/packages/social-controllers/src/social-types.ts b/packages/social-controllers/src/social-types.ts index 5b18165aac1..efa5fd12502 100644 --- a/packages/social-controllers/src/social-types.ts +++ b/packages/social-controllers/src/social-types.ts @@ -133,6 +133,7 @@ export type TraderProfileResponse = { // --------------------------------------------------------------------------- export type Position = { + positionId: string; tokenSymbol: string; tokenName: string; tokenAddress: string; From 27e303a2be2c09510e89cfa5e611a13d12ae0ada Mon Sep 17 00:00:00 2001 From: Joao Santos Date: Fri, 24 Apr 2026 13:07:19 +0200 Subject: [PATCH 2/2] chore: update changelog --- packages/social-controllers/CHANGELOG.md | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/packages/social-controllers/CHANGELOG.md b/packages/social-controllers/CHANGELOG.md index 8e3e9112ab4..c821dd927f5 100644 --- a/packages/social-controllers/CHANGELOG.md +++ b/packages/social-controllers/CHANGELOG.md @@ -7,6 +7,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 ## [Unreleased] +### Added + +- Add `positionId` field to `Position` type and `PositionStruct` validation schema ([#8576](https://github.com/MetaMask/core/pull/8576)) + ## [2.0.0] ### Changed