Skip to content

Conversation

@rickycodes
Copy link
Contributor

@rickycodes rickycodes commented Jul 29, 2022

When we updated the configuration to cut releases from main in #863 I added a script that checks to ensure the version has been incremented before continuing with the release. I've now gone ahead and authored a separate GitHub action (MetaMask/action-is-release) to accomplish this so we no longer need to have this script littered across repositories that set up automatic publishing

I've tested this out in my fork and you can view the action run here:
https://github.com/rickycodes/controllers/actions/runs/2782923007

@rickycodes rickycodes requested review from Gudahtt and mcmire July 29, 2022 18:12
@rickycodes rickycodes marked this pull request as ready for review July 29, 2022 18:14
@rickycodes rickycodes requested a review from a team as a code owner July 29, 2022 18:14
@rickycodes rickycodes force-pushed the use-action-is-release branch from 029a836 to 1f81518 Compare July 29, 2022 18:22
Copy link
Contributor

@mcmire mcmire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Gudahtt Gudahtt changed the title use MetaMask/action-is-relaese@v1.0 use MetaMask/action-is-release@v1.0 Jul 29, 2022
Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rickycodes rickycodes merged commit dc32d17 into main Aug 2, 2022
@rickycodes rickycodes deleted the use-action-is-release branch August 2, 2022 15:29
MajorLift pushed a commit that referenced this pull request Oct 11, 2023
* use MetaMask/action-is-release@v1.0

* delete script
MajorLift pushed a commit that referenced this pull request Oct 11, 2023
* use MetaMask/action-is-release@v1.0

* delete script
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants