From 59eff36f5019ae3fb75614b88b401b82fd3ac4f4 Mon Sep 17 00:00:00 2001 From: Charly Chevalier Date: Wed, 27 May 2026 15:22:16 +0200 Subject: [PATCH 1/2] chore(keyring-controller): deprecate KeyringTypes --- packages/keyring-controller/CHANGELOG.md | 2 ++ packages/keyring-controller/src/KeyringController.ts | 4 ++++ 2 files changed, 6 insertions(+) diff --git a/packages/keyring-controller/CHANGELOG.md b/packages/keyring-controller/CHANGELOG.md index 3b7f33d498..5c250dd1c8 100644 --- a/packages/keyring-controller/CHANGELOG.md +++ b/packages/keyring-controller/CHANGELOG.md @@ -11,6 +11,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 - **BREAKING:** Change `KeyringSelectorV2` type selectors for `withKeyringV2` and `withKeyringV2Unsafe` to use `KeyringType` (v2 variant) ([#8901](https://github.com/MetaMask/core/pull/8901)) - Use values such as `KeyringType.Hd` instead of legacy `KeyringTypes.hd`. +- Deprecate `KeyringTypes` ([#TODO](https://github.com/MetaMask/core/pull/TODO)) + - Use `KeyringTypes` from `@metamask/keyring-api/v2` if your keyring has a v2 builder. ## [25.5.0] diff --git a/packages/keyring-controller/src/KeyringController.ts b/packages/keyring-controller/src/KeyringController.ts index 90e32fef62..a1880da21c 100644 --- a/packages/keyring-controller/src/KeyringController.ts +++ b/packages/keyring-controller/src/KeyringController.ts @@ -94,6 +94,10 @@ const MESSENGER_EXPOSED_METHODS = [ /** * Available keyring types + * + * @deprecated Use `KeyringType` from `@metamask/keyring-api/v2` instead. This enum will be removed + * in a future release once V2 is fully adopted. Only use it if the keyring you are trying to access + * has no V2 builder available yet. */ export enum KeyringTypes { // Changing this would be a breaking change, and not worth the effort at this From b472f9a63c66c502be9828a8509ec8b0454ea1f7 Mon Sep 17 00:00:00 2001 From: Charly Chevalier Date: Wed, 27 May 2026 15:23:13 +0200 Subject: [PATCH 2/2] chore: changelog --- packages/keyring-controller/CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/keyring-controller/CHANGELOG.md b/packages/keyring-controller/CHANGELOG.md index 5c250dd1c8..a0f10e9c7b 100644 --- a/packages/keyring-controller/CHANGELOG.md +++ b/packages/keyring-controller/CHANGELOG.md @@ -11,7 +11,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 - **BREAKING:** Change `KeyringSelectorV2` type selectors for `withKeyringV2` and `withKeyringV2Unsafe` to use `KeyringType` (v2 variant) ([#8901](https://github.com/MetaMask/core/pull/8901)) - Use values such as `KeyringType.Hd` instead of legacy `KeyringTypes.hd`. -- Deprecate `KeyringTypes` ([#TODO](https://github.com/MetaMask/core/pull/TODO)) +- Deprecate `KeyringTypes` ([#8907](https://github.com/MetaMask/core/pull/8907)) - Use `KeyringTypes` from `@metamask/keyring-api/v2` if your keyring has a v2 builder. ## [25.5.0]