feat: add @metamask/network-connection-banner-controller#9041
Draft
cryptodev-2s wants to merge 10 commits into
Draft
feat: add @metamask/network-connection-banner-controller#9041cryptodev-2s wants to merge 10 commits into
cryptodev-2s wants to merge 10 commits into
Conversation
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
cryptodev-2s
force-pushed
the
wpc-1014-network-connection-banner-controller
branch
2 times, most recently
from
9111156 to
d1fa945
Compare
Contributor
Author
|
@metamaskbot publish-preview |
Contributor
|
Preview builds have been published. Learn how to use preview builds in other projects. Expand for full list of packages and versions. |
…riod in changelog
cryptodev-2s
force-pushed
the
wpc-1014-network-connection-banner-controller
branch
from
7507a11 to
612f8a3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
The RPC connection banner ("Still connecting" / "Unable to connect") is currently rendered by both
metamask-extensionandmetamask-mobilebased on duplicated logic in each repo:pslso a single provider's wide outage doesn't pop the banner.{ chainId, networkName, rpcUrl, isInfuraEndpoint, infuraNetworkClientId }payload shape.Every tweak — a rule refinement, an analytics property, an edge-case fix — has to land in both repos. The recent Cursor-bot exchange on the mobile PR around the all-down rule made the maintenance cost visible.
This PR introduces
@metamask/network-connection-banner-controllerso there's a single source of truth. The controller:NetworkController:stateChanged,NetworkEnablementController:stateChanged, andConnectivityController:stateChangedvia the messenger.{ status: 'available' | 'degraded' | 'unavailable', network: FailedNetwork | null }that clients subscribe to.dismissBanner()andswitchToDefaultInfuraRpc({ chainId })— the latter looks up the chain's first Infura endpoint and callsNetworkController:updateNetworkwithreplacementSelectedRpcEndpointIndex.Clients will subsequently migrate to consume this controller state and only own rendering + click handlers. Those migrations are out of scope here.
Layout mirrors
@metamask/connectivity-controllerexactly: samepackage.jsonshape, sametsconfig.json/tsconfig.build.json/jest.config.jspatterns, same auto-generated*-method-action-types.ts, samewithController+getRootMessengertest scaffold. The eTLD+1 logic andisLocalhostOrIPAddressare lifted verbatim from the extension'sshared/lib/url-utils.ts(and the mobile equivalent inapp/util/url-utils.ts), where they shipped reviewed and tested.psl1.15 ships itstypesfield outside itsexportsmap so TypeScript'snode16module resolution can't find it; a small ambientsrc/psl.d.tsshim mirrors the workaround already in use in extension and mobile.ip-regexis pinned to^4.3.0(last CJS release) because the monorepo's Jest config doesn't transform ESM-only deps.100% test coverage across the new package, mirroring the rule cases that landed in the merged extension PR and the in-flight mobile PR: single-Infura suppression, Infura-wide outage suppression, multi-domain trigger, custom override, all-down escape hatch, offline short-circuit, switch-to-Infura dispatch.
References
Checklist