-
Notifications
You must be signed in to change notification settings - Fork 5.1k
Comparing changes
Open a pull request
base repository: MetaMask/metamask-extension
base: v10.11.2
head repository: MetaMask/metamask-extension
compare: v10.11.3
- 14 commits
- 76 files changed
- 3 contributors
Commits on Mar 21, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 716931a - Browse repository at this point
Copy the full SHA 716931aView commit details -
Refactor: Extract SRP input from create vault component (#13720)
This is a pure refactor that extracts the SRP input from the `CreateNewVault` component. This is intended to make future changes to the SRP input easier, and to reduce duplication between the old and new onboarding flows. Extensive unit tests have been added for the new SRP input component. A new test library was added (`@testing-library/user-event`) for simulating user events with components rendered using the `@testing-library` library. A new helper method has been added (`renderWithLocalization`) for rendering components using `@testing-library` with just our localization contexts added as a wrapper. The localization contexts were already added by the `renderWithProviders` helper function, but there is no need for a Redux provider in these unit tests.
Configuration menu - View commit details
-
Copy full SHA for 22f9de9 - Browse repository at this point
Copy the full SHA 22f9de9View commit details -
Improve unit tests for
SrpInputcomponent (#13803)The library `@testing-library/user-event` has been updated to the latest beta version, so that our unit tests better model real user interactions. In particular, I found that previously the `paste` event was missing the `clipboardData` API, so it was impossible to implement any custom handling of paste events (which we will need in later PRs). See the `v14.0.0-beta.1` release notes for a list of all breaking changes [1]. The main change is that all methods now return Promises. The `paste` method has also been dramatically simplified. The unit tests have also been updated to reset all mocks before each test. These tests don't have any shared mocks, but this is generally a good practice, to ensure that tests don't develop accidental inter- dependencies. [1]: https://github.com/testing-library/user-event/releases/tag/v14.0.0-beta.1
Configuration menu - View commit details
-
Copy full SHA for 1eecc59 - Browse repository at this point
Copy the full SHA 1eecc59View commit details -
Add
data-test-idprop toTextFieldcomponent (#13973)The `data-test-id` prop has been added to `TextField`. This prop allows selecting this component more easily from e2e and unit tests. This is required for a subsequent PR that includes a text field that cannot be selected for by placeholder or contents or label (any of which would have been preferable).
Configuration menu - View commit details
-
Copy full SHA for 851f9b3 - Browse repository at this point
Copy the full SHA 851f9b3View commit details -
Add
IconEyeandIconEyeSlashicon components (#13978)Add two new FontAwesome icon components. The first is an eye, and the second is an eye with a slash through it. These will be used in a subsequent PR for a "Show/Hide" toggle.
Configuration menu - View commit details
-
Copy full SHA for c154145 - Browse repository at this point
Copy the full SHA c154145View commit details -
Add
pasteIntoFieldwebdriver method (#14004)A new method has been added to the e2e webdriver for pasting text into a field. This will be required to properly test a change to the SRP input, which will be coming in a separate PR. A few existing e2e tests have been updated to use this method to input the SRP, to show that it works properly.
Configuration menu - View commit details
-
Copy full SHA for 35f5127 - Browse repository at this point
Copy the full SHA 35f5127View commit details -
Add
ShowHideTogglecomponent (#13979)Add a new component for controlling whether a field should be shown or hidden. This will be used in later PRs as a control for sensitive fields that are hidden by default. This component should be fully accessible. Both mouse and keyboard interactions have been tested, and `aria-label` attributes have been added to explain the two "eye" icons that don't have any corresponding text. Thorough unit tests have been written, testing all props except `className` (I don't know how to test that using Jest/`jsdom`).
Configuration menu - View commit details
-
Copy full SHA for 4adadd3 - Browse repository at this point
Copy the full SHA 4adadd3View commit details -
Split SRP input by word (#14016)
* Initial implementation of new SrpInput component This new version of the SrpInput component uses a separate field for each word of the SRP. Only one field can be revealed at a time, making it less likely that it gets accidentally revealed to somebody. * Fix copy mistakes * Move container div from 'create vault' to 'srp-input', and setup grid layout * Increase size of title * Remove hard-coded width in Storybook to allow testing different viewport sizes * Improve layout * Improve margins * Update dropdown text * Expand SRP input section * Remove unused localized messages * Update dropdown option names in unit tests * Replace checkbox with show/hide toggle * Remove unused localized message * Fix 'data-testid' prop name * Fix e2e test imports using paste * Use 'ActionableMessage' component for error message * Convert error popover to actionable message * Add tip about pasting the SRP * Remove invalid prop The "info" style of `ActionableMessage` is the default, so no type is required. * Use more readable test convenience methods The method `toBeInTheDocument()` is now used over `not.toBeNull()` to improve the readability of tests. Likewise, the convenience method `.clear` is now used to clear fields rather than manually entering the key combination to clear a field. * Fix misspelled word
Configuration menu - View commit details
-
Copy full SHA for 00341cd - Browse repository at this point
Copy the full SHA 00341cdView commit details
Commits on Mar 22, 2022
-
Fix SrpInput small viewport styles (#14087)
The styles for smaller viewports were broken because I forgot to update the small-screen grid template after adding the "paste-tip". The styles have now been updated to fit the content properly on all of our supported screen sizes.
Configuration menu - View commit details
-
Copy full SHA for 49e65a7 - Browse repository at this point
Copy the full SHA 49e65a7View commit details -
The lockfile became invalid due to dependencies introduced in cherry- picked commits.
Configuration menu - View commit details
-
Copy full SHA for 8b10b85 - Browse repository at this point
Copy the full SHA 8b10b85View commit details -
Configuration menu - View commit details
-
Copy full SHA for 47c4409 - Browse repository at this point
Copy the full SHA 47c4409View commit details -
Configuration menu - View commit details
-
Copy full SHA for 24222fb - Browse repository at this point
Copy the full SHA 24222fbView commit details -
The Yarn resolution for `node-forge` has been updated to use a more recent version of the library that includes fixes for the vulnerabilities currently causing our audit job to fail. This update should include no breaking changes.
Configuration menu - View commit details
-
Copy full SHA for 2779756 - Browse repository at this point
Copy the full SHA 2779756View commit details -
Merge pull request #14085 from MetaMask/Version-v10.11.3
Version v10.11.3 RC
Configuration menu - View commit details
-
Copy full SHA for a87c84e - Browse repository at this point
Copy the full SHA a87c84eView commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff v10.11.2...v10.11.3