New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display address as ERC-67 #1479

Closed
ligi opened this Issue May 23, 2017 · 2 comments

Comments

Projects
None yet
4 participants
@ligi

ligi commented May 23, 2017

Currently when showing the barcode for the account metamask displays the raw hex string. But it would be good if context is supplied via e.g. ERC-67 (ethereum/EIPs#67)

metamask

one concrete use-case. On android you would currently have to go in the app and then scan. This way we can use intent-filters to scan with any app and then redirect to the right one.
Also as it is in the same screen (let me know if I should open an new issue for this) - the clipboard button is quite prominent and gives no warning - but this is risky thing - the same thing applies for metamask usage on PC as this problem on android: walleth/walleth#14

@Zanibas Zanibas added this to the Core Maintenance milestone May 30, 2017

@ligi

This comment has been minimized.

Show comment
Hide comment
@ligi

ligi Jul 14, 2017

Just tried it out - is ERC-67 now - thanks!

ligi commented Jul 14, 2017

Just tried it out - is ERC-67 now - thanks!

@ligi ligi closed this Jul 14, 2017

@kumavis

This comment has been minimized.

Show comment
Hide comment
@kumavis

kumavis Jul 14, 2017

Member

sorry we forgot to update this ticket
thanks for filing the issue!

Member

kumavis commented Jul 14, 2017

sorry we forgot to update this ticket
thanks for filing the issue!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment