[Bug]: Forget this device removes account from keyring, but not the UI

[plasmacorral]

Describe the bug

When I have a hardware wallet present, and I go thru the add new hardware flow to select Forget device the account remains in the drop-down list.

In the branch I was testing at the time, I found that the accounts cannot be subsequently removed as they no longer exist in the keyring after the device was forgotten. This has been observed on both Keystone and Ledger within the changes from PR 21437, and likely impacts both Trezor and Lattice. Was able to confirm that this behavior is present in production 11.4.0 and 11.4.1.

Note that starting with step 11 below, the inability to remove the account is limited to the branch under test. In 11.4.0 I can still remove an address from the list after I try to forget the device (but should not actually have to). However, that is not the case in the changes that were being tested and I am unable to remove the addresses.

Expected behavior

When the user selects Forget this device any associated accounts should be removed from the keyring AND no longer displayed in the accounts list.

User should be able to remove any accounts that are not derived from the SRP.

Screenshots/Recordings

11.4.0: ABLE to remove individual accounts after Forget this device fails: https://recordit.co/BV2omOAjFk

PR 21437 commit 141b1ef: UNABLE to remove individual accounts after Forget this device fails: https://recordit.co/qhg25TCZy9

Steps to reproduce

1. Have hardware addresses already added in a configured wallet
2. Tap accounts drop down
3. tap Add account of hardware wallet
4. tap Add hardware wallet
5. Select the hardware wallet you are testing with
6. If Ledger- you may need to tap Connect on HID device connection prompt
7. Tap Continue
8. Once account list is displayed tap Forget this device
9. In the branch under test the address list page will re-appear with a notification that hardware is connected. If so, go ahead and tap Forget this device a second time.
10. Tap the accounts drop down and note that hardware address that should be forgotten is displayed in the list
11. Hit the kebab next to a given hardware account
12. tap remove account
13. Tap Remove
14. Note that dialog remains open and account is not removed

Error messages or log output

KeyringController - No keyring found. Error info: There are keyrings, but none match the address

Version

11.4.0

Build type

None

Browser

Chrome

Operating system

MacOS

Hardware wallet

Ledger, Keystone

Additional context

Can remove individual addresses as long as the user does not first try to forget the device.

Severity

Would be incredibly frustrating to land in a spot where accounts cannot be removed that do not exist in the keyring.