Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: eth_signTransaction #2506

Closed
tomusdrw opened this issue Oct 30, 2017 · 8 comments
Closed

Feature: eth_signTransaction #2506

tomusdrw opened this issue Oct 30, 2017 · 8 comments
Labels
area-nonce Relating to tx nonce logic area-provider Relating to the provider module. type-enhancement

Comments

@tomusdrw
Copy link

Any plans to support eth_signTransaction method?

The methods allows to sign a transaction request (same as eth_sendTransaction), but without submitting it to the network. That's useful e.g for scheduling transaction to run in a specific time. Example of such dapp can be found here: https://txsched.parity.io

Unfortunatelly details are only in this PR, the method is not documented on the wiki:
ethereum/go-ethereum#1666

@rawadrifai
Copy link

any updates on this?
I'm getting this error: Method eth_signTransaction not supported
This is the line of code:
let signed = await this.adapter.web3.eth.signTransaction(data, coinbase);

@kumavis kumavis changed the title Support eth_signTransaction Feature: eth_signTransaction May 12, 2018
@kumavis kumavis added type-enhancement P4-someday area-provider Relating to the provider module. area-nonce Relating to tx nonce logic and removed T05-userQuestion labels May 12, 2018
@kumavis
Copy link
Member

kumavis commented May 12, 2018

Supporting this allows dapps to "brick" a metamask account by consuming a nonce and never submitting the transaction.

This could be mitigated by dapp-specific accounts or retry (re-publish ourselves) and cancel (empty tx at same nonce) buttons. Currently our transaction controller regularly republishes transactions to ensure they stay in the mempool, so we'd also have to disable that.

@neilpalima
Copy link

is there any timeline or date for the possible support of signTransaction?

@sidsverma
Copy link

This is the same as #3475.

@john-osullivan
Copy link

While the concerns about bricking an account are real, supporting this call would also make it easier for users to interact with dapps on other networks without having to update their Metamask provider list. Metamask's use is a lot broader if it can be treated as a client's generalized signing tool.

@deacix
Copy link

deacix commented Dec 4, 2020

Hey guys! We need this feature! Check this out: https://twitter.com/1inchExchange/status/1334992381242961930?s=20

@kissiga
Copy link

kissiga commented Jan 25, 2021

Any update or ETA please?

@eccentricexit
Copy link

eccentricexit commented Feb 21, 2021

Do you know which wallets that support this? Please comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-nonce Relating to tx nonce logic area-provider Relating to the provider module. type-enhancement
Projects
None yet
Development

No branches or pull requests