Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MetaMask interferes with Google Voice and/or Google Hangouts #3272

Closed
andrewbrey opened this issue Feb 16, 2018 · 6 comments
Closed

MetaMask interferes with Google Voice and/or Google Hangouts #3272

andrewbrey opened this issue Feb 16, 2018 · 6 comments
Labels
area-injection Relating to how the JS interface is injected into a website. type-bug

Comments

@andrewbrey
Copy link

Chrome Version: Version 64.0.3282.167 (Official Build) (64-bit)
MetaMask Version: 3.14.1

Issue: Answering and making voice calls with Google Voice/Google Hangouts is not possible if the MetaMask extension is installed (and enabled). The Google Voice call dialog has a button to answer incoming calls that is somehow being rendered inert by MetaMask. Clicking the hangup button works, but answering calls doesn't. Similarly, attempts to make a call from Google Voice and/or Hangouts are foiled. This leads me to believe that MetaMask is causing an issue in the network calls made to Google servers to establish a connection to make (or take) a call.

Here is a Google product forum post from Feb 2018 complaining of the exact symptoms, including an ultimate resolution that the user had recently installed an extension that proved to be causing the issue (I suspect MetaMask is a possible culprit here too): https://productforums.google.com/d/msg/hangouts/Ao2vVL8yFS4/ruL1BkwrAAAJ

I also confirmed that in my incognito window (where MetaMask is disabled for me as I haven't given it permission to run in incognito) that my Google Voice calls work fine, and I can trigger the inability to call by letting MetaMask run in incognito and then refreshing my Hangouts tab (which causes the MetaMask content scripts to be installed).

@2-am-zzz 2-am-zzz added P1-asap type-bug area-injection Relating to how the JS interface is injected into a website. labels Feb 26, 2018
@2-am-zzz
Copy link
Contributor

This requires us to implement the per-login architecture. Thank you for bringing this up--this definitely ups our priority on this.

@2-am-zzz 2-am-zzz removed their assignment Feb 26, 2018
@bluet
Copy link

bluet commented Mar 5, 2018

The same issue happens on Firefox too.
#2838

@danfinlay
Copy link
Contributor

We believe this may be fixed in production, could you please verify?

Our team uses hangouts all the time, so we have failed to reproduce. Any other system specific information could be helpful.

@andrewbrey
Copy link
Author

I just did some tests of both making and receiving calls and found that both worked. This issue was reported against MM 3.14.1 and Chrome 64. I'm now on MM 4.6.1 and Chrome 66, so if you made no specific code change to address this on the MM side, then it appears that either a Chrome update resolved it, or an unrelated MM code change somewhere between versions 3.14.1 and 4.6.1 resolved it as a side effect.

I did not test this in Firefox, and as is mentioned previously in the thread, #2838 indicates that this issue was also present there - it would be good if a Firefox user could confirm that it is fixed for FF as well. As long as MM is only available for Evergreen browsers (and assuming someone on FF confirms that it's fixed there too), I don't see why this issue couldn't be closed.

@danfinlay
Copy link
Contributor

Great, thanks for verifying @andrewbrey. Leaving open for a Firefox user to confirm.

@bdresser
Copy link
Contributor

Fixed by #4592, please let us know if you still have trouble

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-injection Relating to how the JS interface is injected into a website. type-bug
Projects
None yet
Development

No branches or pull requests

5 participants