Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENS Subdomain Eager Resolve #4380

Closed
BKDaugherty opened this issue May 27, 2018 · 6 comments
Closed

ENS Subdomain Eager Resolve #4380

BKDaugherty opened this issue May 27, 2018 · 6 comments

Comments

@BKDaugherty
Copy link

@BKDaugherty BKDaugherty commented May 27, 2018

Metamask is a little to eager in trying to resolve my ENS subdomain! It works great when I copy and paste the ens name in, but doesn't do too well when I type it!

metamaskbug

  • Expected Behavior : Resolved ENS Subdomain after I finish typing it in.
  • Actual Behavior: Eager resolve before I have finished
  • Browser Used: Chrome
  • Operating System : MacOS High Sierra 10.13.3
@danfinlay
Copy link
Contributor

@danfinlay danfinlay commented Jun 20, 2018

I agree, we could save the validation for either:

  • on submit
  • once the string ens with a tld (should have a period between two non-zero length strings)

@danjm
Copy link
Contributor

@danjm danjm commented Jun 25, 2018

once the string ens with a tld (should have a period between two non-zero length strings)

We already do this. So perhaps we just need to increase the delay on the debounce.

@briansoule
Copy link
Contributor

@briansoule briansoule commented Aug 4, 2018

It seems to work properly in the old UI

@Arachnid
Copy link

@Arachnid Arachnid commented Aug 4, 2018

Could you just leave it as the name? Replacing it with the address in the input field isn't ideal.

@lyricalpolymath
Copy link

@lyricalpolymath lyricalpolymath commented Sep 19, 2018

the resolution should be verified after the user is done entering the .eth or any other TLD (since now ens supports .xyz and will soon support more)

also agree with Nick that the name should stay visible
and as I wrote here #4616 (comment)
.... probably ALSO display a greyed out and shorthand version of the address

@Gudahtt
Copy link
Member

@Gudahtt Gudahtt commented Jan 6, 2021

Our UI has changed quite a bit since this was first reported; this now appears to be fixed

@Gudahtt Gudahtt closed this Jan 6, 2021
@Gudahtt Gudahtt removed the P2-sooner label Jan 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
8 participants