Fix built-in networks switch-ethereum-chain, Including RPC url in switchEthereumChain requestData #11268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`switch-ethereum-chain` did not work correctly with built-in networks. It was treating them as custom networks, rather than as built-in networks. This affected how they were displayed in the network dropdown, and resulted in slight differences to the network stack used as well. The problem was that `updateRpcTarget` was used, which was meant for custom networks only. Now that `setProviderType` is used in the case of a built-in network, the behaviour should match the network switcher exactly.
Builds ready [92480f1]
Page Load Metrics (592 ± 49 ms)
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: #11184 - test plan should be similar