Fixed hardware wallet info popup on token allowance screen #17881
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Builds ready [4c1972d]
Page Load Metrics (1706 ± 59 ms)
Bundle size diffs
|
|
Verified by QA |
jpuri
reviewed
Feb 24, 2023
| <Box paddingLeft={2} paddingRight={2}> | ||
| <LedgerInstructionField showDataInstruction /> | ||
| </Box> | ||
| )} |
There was a problem hiding this comment.
Hey will be nice to have test coverage for above.
There was a problem hiding this comment.
Added here: ce80c0e
brad-decker
requested changes
Feb 28, 2023
| <Box paddingLeft={2} paddingRight={2}> | ||
| <LedgerInstructionField showDataInstruction /> | ||
| </Box> | ||
| )} |
filipsekulic
force-pushed
the
fix/show-hardware-wallet-info-on-token-allowance-screen
branch
from
4c1972d
to
b3ee025
Compare
filipsekulic
force-pushed
the
fix/show-hardware-wallet-info-on-token-allowance-screen
branch
from
ce80c0e
to
23b9e71
Compare
Builds ready [40b9362]
Page Load Metrics (1517 ± 63 ms)
Bundle size diffs
|
digiwand
reviewed
Mar 3, 2023
| const textField = getByTestId('custom-spending-cap-input'); | ||
| fireEvent.change(textField, { target: { value: '1' } }); | ||
|
|
||
| const nextButton = getByText('Next'); |
There was a problem hiding this comment.
nice! tests look good. could be handy to add an additional null check to check the text is not showing on the first page
Suggested change
| const nextButton = getByText('Next'); | |
| expect(queryByText('Prior to clicking confirm:')).toBeNull(); | |
| const nextButton = getByText('Next'); |
There was a problem hiding this comment.
Good suggestion! Thanks!
Changed it here: 455663d
Builds ready [455663d]
Page Load Metrics (1697 ± 77 ms)
Bundle size diffs
|
Codecov Report
@@ Coverage Diff @@
## develop #17881 +/- ##
===========================================
+ Coverage 63.45% 63.55% +0.11%
===========================================
Files 903 903
Lines 35264 35267 +3
Branches 8919 8921 +2
===========================================
+ Hits 22374 22413 +39
+ Misses 12890 12854 -36
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
jpuri
previously approved these changes
Mar 7, 2023
filipsekulic
force-pushed
the
fix/show-hardware-wallet-info-on-token-allowance-screen
branch
from
455663d
to
5857fc5
Compare
Builds ready [5857fc5]
Page Load Metrics (1516 ± 50 ms)
Bundle size diffs
|
jpuri
approved these changes
Mar 8, 2023
brad-decker
approved these changes
Mar 14, 2023
brad-decker
deleted the
fix/show-hardware-wallet-info-on-token-allowance-screen
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
Screenshots/Screencaps
After
After.mov
Manual Testing Steps
https://metamask.github.io/test-dapp/