Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I#5956 fix 1 #6026

Merged
merged 5 commits into from Jan 17, 2019

Conversation

@frankiebee
Copy link
Member

commented Jan 16, 2019

this is a partial fix for #5956 but this is will prevent users from setting non number chainId's for custom rpcs as well as migrate storage to remove past NaN chainId's

fix two will be on it's way shortly hopefully fixing the caching problem

@frankiebee frankiebee requested review from alextsg, danjm and whymarrh as code owners Jan 16, 2019
…oller for custom rpcs
@frankiebee frankiebee force-pushed the i#5956-fix1 branch from 4d1ab14 to adbd433 Jan 16, 2019
frankiebee added 2 commits Jan 16, 2019
Copy link
Contributor

left a comment

Seems like a very simple change, with a good migration and test to fix those cases. Happy to merge.

I'm surprised to hear that some of the problem had been people setting non-numeric chain IDs. How did we confirm that?

@danfinlay

This comment has been minimized.

Copy link
Contributor

commented Jan 17, 2019

Looks like you'll need to pull in develop to disable the drizzle tests that seem to have been broken with some truffle update.

@frankiebee

This comment has been minimized.

Copy link
Member Author

commented Jan 17, 2019

@danfinlay it's actually an issue with how the network dropdown works and this was a side affect bug. but the network dropdown fix is up next

@metamaskbot

This comment has been minimized.

Copy link
Collaborator

commented Jan 17, 2019

Builds ready [b4284ad]: mascara, chrome, firefox, edge, opera
@frankiebee frankiebee merged commit 0ad7797 into develop Jan 17, 2019
16 checks passed
16 checks passed
ci/circleci: all-tests-pass Your tests passed on CircleCI!
Details
ci/circleci: job-publish-prerelease Your tests passed on CircleCI!
Details
ci/circleci: job-screens Your tests passed on CircleCI!
Details
ci/circleci: prep-build Your tests passed on CircleCI!
Details
ci/circleci: prep-deps-npm Your tests passed on CircleCI!
Details
ci/circleci: prep-docs Your tests passed on CircleCI!
Details
ci/circleci: prep-scss Your tests passed on CircleCI!
Details
ci/circleci: test-deps Your tests passed on CircleCI!
Details
ci/circleci: test-e2e-beta-chrome Your tests passed on CircleCI!
Details
ci/circleci: test-e2e-beta-firefox Your tests passed on CircleCI!
Details
ci/circleci: test-integration-flat-chrome Your tests passed on CircleCI!
Details
ci/circleci: test-integration-flat-firefox Your tests passed on CircleCI!
Details
ci/circleci: test-lint Your tests passed on CircleCI!
Details
ci/circleci: test-mozilla-lint Your tests passed on CircleCI!
Details
ci/circleci: test-unit Your tests passed on CircleCI!
Details
coverage/coveralls Coverage increased (+0.1%) to 65.942%
Details
@frankiebee frankiebee deleted the i#5956-fix1 branch Jan 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.