Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Connections settings tab #7013

Merged
merged 5 commits into from Aug 15, 2019
Merged

Conversation

@whymarrh
Copy link
Contributor

whymarrh commented Aug 14, 2019

Refs #4703, #6904, #6955

This PR does a few things:

  • This PR removes the Share Address notification added in #6904
  • This PR removes the Privacy Mode toggle from settings
  • This PR introduces a new Connections tab in settings that allows users to add and review sites that have access to their accounts
  • This PR makes the list of connected sites persistent across MetaMask reloads

Some context:

  • As of #6904 (released in v7.0.0) Privacy Mode is on by default for all new users
  • Any existing users have/will be migrated to Privacy Mode
  • Privacy Mode means that sites must request account access à la EIP-1102 (or, as of this PR, they can be explicitly added)
Screenshots

Some finer details:

  • The input for adding a site doesn't currently enforce a valid domain
  • The input for adding a site IS pre-populated in the popup (via the browser action) with the active tab's origin
@whymarrh whymarrh force-pushed the whymarrh:connected-dapps-settings branch 2 times, most recently from 29a6143 to dd29ae6 Aug 15, 2019
@danjm

This comment has been minimized.

Copy link
Contributor

danjm commented Aug 15, 2019

First question I have is whether we are certain we want to persist all connect request approvals? This will be a change in user experience. Might there be some users who like the default of these not being persisted?

@whymarrh

This comment has been minimized.

Copy link
Contributor Author

whymarrh commented Aug 15, 2019

  1. I feel like it is an improvement in the UX (that is, I think it is a good idea and I stand by it)
  2. I can drop dd29ae6 if we don't, no sweat
@Gudahtt

This comment has been minimized.

Copy link
Contributor

Gudahtt commented Aug 15, 2019

First question I have is whether we are certain we want to persist all connect request approvals? This will be a change in user experience. Might there be some users who like the default of these not being persisted?

Good point. While I'm sure most users would prefer them be persisted, there are sure to be those that prefer nothing to be saved between sessions.

The ideal solution might be a toggle, perhaps? One that defaults to persisting connections. I'm not sure how important that'd be to include in this release though. 🤔

@whymarrh

This comment has been minimized.

Copy link
Contributor Author

whymarrh commented Aug 15, 2019

The ideal solution might be a toggle, perhaps? One that defaults to persisting connections. I'm not sure how important that'd be to include in this release though. 🤔

I don't think that's quite ideal. I think we can comfortably pick one way and stick with it.

@whymarrh whymarrh force-pushed the whymarrh:connected-dapps-settings branch from dd29ae6 to 5bbda44 Aug 15, 2019
@danjm

This comment has been minimized.

Copy link
Contributor

danjm commented Aug 15, 2019

First question I have is whether we are certain we want to persist all connect request approvals? This will be a change in user experience. Might there be some users who like the default of these not being persisted?

I guess the remove all button is there for users who really care

@Gudahtt

This comment has been minimized.

Copy link
Contributor

Gudahtt commented Aug 15, 2019

I don't think that's quite ideal. I think we can comfortably pick one way and stick with it.

I was thinking of it like an "Incognito mode". Certainly nothing we need right now though, granted.

Copy link
Contributor

Gudahtt left a comment

Looks good! I noticed a few stray props that should be removed, but everything's good aside from that.

app/scripts/metamask-controller.js Show resolved Hide resolved
ui/app/pages/home/home.component.js Show resolved Hide resolved
@whymarrh whymarrh force-pushed the whymarrh:connected-dapps-settings branch from 5bbda44 to a6b254f Aug 15, 2019
@danjm
danjm approved these changes Aug 15, 2019
app/_locales/ht/messages.json Show resolved Hide resolved
@whymarrh whymarrh merged commit 247659c into MetaMask:develop Aug 15, 2019
13 of 14 checks passed
13 of 14 checks passed
ci/circleci: test-unit Your tests failed on CircleCI
Details
ci/circleci: all-tests-pass Your tests passed on CircleCI!
Details
ci/circleci: coveralls-upload Your tests passed on CircleCI!
Details
ci/circleci: job-publish-prerelease Your tests passed on CircleCI!
Details
ci/circleci: prep-build Your tests passed on CircleCI!
Details
ci/circleci: prep-deps Your tests passed on CircleCI!
Details
ci/circleci: prep-scss Your tests passed on CircleCI!
Details
ci/circleci: test-deps Your tests passed on CircleCI!
Details
ci/circleci: test-e2e-chrome Your tests passed on CircleCI!
Details
ci/circleci: test-e2e-firefox Your tests passed on CircleCI!
Details
ci/circleci: test-integration-flat-chrome Your tests passed on CircleCI!
Details
ci/circleci: test-integration-flat-firefox Your tests passed on CircleCI!
Details
ci/circleci: test-lint Your tests passed on CircleCI!
Details
ci/circleci: test-mozilla-lint Your tests passed on CircleCI!
Details
@whymarrh whymarrh deleted the whymarrh:connected-dapps-settings branch Aug 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.