Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Permit all-caps addresses #9227

Merged
merged 2 commits into from Aug 14, 2020

Conversation

PatrykLucka
Copy link
Contributor

Allows to use all-caps addresses - was not sure about '0X' prefix, but I checked that Etherscan allows to use such prefix, so added it here as well.

Fixes #9175

@PatrykLucka PatrykLucka requested a review from a team as a code owner August 14, 2020 09:34
Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Gudahtt Gudahtt merged commit aad8407 into MetaMask:develop Aug 14, 2020
Gudahtt pushed a commit that referenced this pull request Aug 14, 2020
* permit all-caps addresses

* handle empty address
@metamaskbot metamaskbot mentioned this pull request Aug 14, 2020
Gudahtt added a commit that referenced this pull request Aug 14, 2020
* origin/develop: (107 commits)
  Clear Account Details in AppState (#9238)
  Permit all-caps addresses (#9227)
  Send web3 usage metrics once per origin/property (#9237)
  Fix import/no-extraneous-dependencies issues (#9232)
  Remove unused buyEth fn from bg (#9236)
  Fix max-statements-per-line issues (#9218)
  Consolidate ESLint config files (#9231)
  Delete page-container.component.test.js (#9229)
  Tidy up getAccountLink (#9223)
  Tidy ConnectHardwareForm#checkIfUnlocked (#9224)
  Fix require-unicode-regexp issues (#9212)
  Fix no-negated-condition issues (#9222)
  Fix no-empty-function issues (#9216)
  Fix import/extensions issues (#9217)
  Dedupe glob-parent versions (#9220)
  Fix no-template-curly-in-string issues (#9221)
  Fix no-process-exit issues (#9219)
  Fix prefer-rest-params issues (#9215)
  Fix no-prototype-builtins issues (#9213)
  Fix no-nested-ternary issues (#9214)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Entering an address in all-caps gets flagged as an invalid address
2 participants