Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove 'Contact us' exclamation mark #9307

Merged
merged 1 commit into from Aug 25, 2020
Merged

Remove 'Contact us' exclamation mark #9307

merged 1 commit into from Aug 25, 2020

Conversation

rekmarks
Copy link
Member

This PR removes the exclamation mark from the "Contact us" locale message, which is both janky and contrary to our style guide.

image

@rekmarks rekmarks requested a review from a team as a code owner August 25, 2020 16:43
@rekmarks rekmarks requested a review from danjm August 25, 2020 16:43
@metamaskbot
Copy link
Collaborator

Builds ready [29550e3]
Page Load Metrics (493 ± 65 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint278937178
domContentLoaded29467549113565
load29567949313665
domInteractive29367549113565

whymarrh
whymarrh approved these changes Aug 25, 2020
View reviewed changes
Copy link
Contributor

@whymarrh whymarrh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rekmarks rekmarks merged commit 867dd33 into develop Aug 25, 2020
@rekmarks rekmarks deleted the contact-us-exclamation-mark-removal branch August 25, 2020 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@whymarrh whymarrh whymarrh approved these changes

@danjm danjm Awaiting requested review from danjm

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rekmarks @metamaskbot @whymarrh