-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: deprecate mumbai and linea goerli #9047
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Bitrise❌❌❌ Commit hash: a408eb1 Note
|
Bitrise✅✅✅ Commit hash: ede413c Note
|
Bitrise✅✅✅ Commit hash: 206eb5f Note
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! Looks good to me.
206eb5f
to
8e237b7
Compare
Bitrise❌❌❌ Commit hash: 8e237b7 Note
|
Bitrise✅✅✅ Commit hash: 7189aa2 Note
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9047 +/- ##
==========================================
+ Coverage 45.35% 45.37% +0.02%
==========================================
Files 1272 1273 +1
Lines 31247 31273 +26
Branches 3189 3195 +6
==========================================
+ Hits 14171 14190 +19
- Misses 16234 16239 +5
- Partials 842 844 +2 ☔ View full report in Codecov by Sentry. |
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
closing this one in favor of this #9224 |
Description
PR to display a warning when a user switches to Mumbai network.
It also removes linea goerli network from being displayed in the test networks section by default.
It migrates users who are on linea goerli network to linea sepolia network.
It displays a warning msg when users switch to linea goerli
Related issues
Fixes:
Related ticket description for context:
Goal: For Linea Goerli, Polygon Mumbai, Op Goerli, Arb Goerli and Starknet Goerli, we need to fully deprecate them.
Starknet is not EVM compatible so we wont worry about it.
1: Add in deprecation message
2: Fully remove mention of them in code
3: Ensure that if a user tried to add / connect to a deprecated network, we tell them it is deprecated.
Key dates for Infura deprecation:
Linea Goerli deprecation: 4/18
Starknet Goerli deprecation: 4/11
Op/Arb: Already deprecated
Polygon Mumbai: TBD
Manual testing steps
Screenshots/Recordings
Before
Screen.Recording.2024-03-25.at.22.04.54.mov
After
Screen.Recording.2024-03-25.at.21.57.56.mov
Pre-merge author checklist
Pre-merge reviewer checklist