Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: deprecate mumbai and linea goerli #9047

Closed
wants to merge 7 commits into from

Conversation

sahar-fehri
Copy link
Contributor

@sahar-fehri sahar-fehri commented Mar 25, 2024

Description

PR to display a warning when a user switches to Mumbai network.
It also removes linea goerli network from being displayed in the test networks section by default.
It migrates users who are on linea goerli network to linea sepolia network.
It displays a warning msg when users switch to linea goerli

Related issues

Fixes:

Related ticket description for context:

Goal: For Linea Goerli, Polygon Mumbai, Op Goerli, Arb Goerli and Starknet Goerli, we need to fully deprecate them.
Starknet is not EVM compatible so we wont worry about it.

1: Add in deprecation message

2: Fully remove mention of them in code

3: Ensure that if a user tried to add / connect to a deprecated network, we tell them it is deprecated.

Key dates for Infura deprecation:

Linea Goerli deprecation: 4/18

Starknet Goerli deprecation: 4/11

Op/Arb: Already deprecated

Polygon Mumbai: TBD

Manual testing steps

  1. Go to home page
  2. Click on network selector, you should not see linea goerli
  3. try switching to linea goerli or Mumbai: To switch to these networks, click on the navigation button in the wallet and type in: chainlist.org. Connect your wallet and you can look for the network you want to add then click on "add to metamask" button (see screenshot)
Screenshot 2024-03-28 at 18 29 00
  1. You should see a deprecation warning msg

Screenshots/Recordings

Before

Screen.Recording.2024-03-25.at.22.04.54.mov

After

Screen.Recording.2024-03-25.at.21.57.56.mov

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've completed the PR template to the best of my ability
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@sahar-fehri sahar-fehri requested a review from a team as a code owner March 25, 2024 15:13
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@sahar-fehri sahar-fehri added team-mobile-ux DEPRECATED: please use "team-wallet-ux" label instead Run Smoke E2E Triggers smoke e2e on Bitrise labels Mar 25, 2024
Copy link
Contributor

github-actions bot commented Mar 25, 2024

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: a408eb1
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/50917c0a-2413-42f7-903b-413ae59ddb3c

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@sahar-fehri sahar-fehri added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Mar 25, 2024
Copy link
Contributor

github-actions bot commented Mar 25, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: ede413c
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/5351ef5f-4e75-4187-961d-92d58ef6c7b6

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@sahar-fehri sahar-fehri marked this pull request as draft March 25, 2024 17:26
@sahar-fehri sahar-fehri added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Mar 25, 2024
Copy link
Contributor

github-actions bot commented Mar 25, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 206eb5f
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/865b13ff-99d3-4aa9-bab9-6d4d7b05b3ea

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@sahar-fehri sahar-fehri marked this pull request as ready for review March 25, 2024 20:59
NicolasMassart
NicolasMassart previously approved these changes Mar 29, 2024
Copy link
Contributor

@NicolasMassart NicolasMassart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! Looks good to me.

@NicolasMassart NicolasMassart added the needs-qa Any New Features that needs a full manual QA prior to being added to a release. label Mar 29, 2024
@sahar-fehri sahar-fehri force-pushed the fix/deprecate-polygon-linea-goerli branch from 206eb5f to 8e237b7 Compare March 31, 2024 20:13
@sahar-fehri sahar-fehri added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Mar 31, 2024
Copy link
Contributor

github-actions bot commented Mar 31, 2024

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 8e237b7
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/956ab559-d32f-48c8-9c1d-c06908589201

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@sahar-fehri sahar-fehri added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Mar 31, 2024
Copy link
Contributor

github-actions bot commented Mar 31, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 7189aa2
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/79564482-3fbc-473d-a86a-78c35b0a4945

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@codecov-commenter
Copy link

codecov-commenter commented Mar 31, 2024

Codecov Report

Attention: Patch coverage is 73.07692% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 45.37%. Comparing base (3f17ad2) to head (7189aa2).

Files Patch % Lines
app/store/migrations/037.ts 81.81% 2 Missing and 2 partials ⚠️
app/components/Nav/Main/index.js 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9047      +/-   ##
==========================================
+ Coverage   45.35%   45.37%   +0.02%     
==========================================
  Files        1272     1273       +1     
  Lines       31247    31273      +26     
  Branches     3189     3195       +6     
==========================================
+ Hits        14171    14190      +19     
- Misses      16234    16239       +5     
- Partials      842      844       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented Mar 31, 2024

Copy link
Contributor

@MarioAslau MarioAslau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@sahar-fehri
Copy link
Contributor Author

sahar-fehri commented Apr 12, 2024

closing this one in favor of this #9224

@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs-qa Any New Features that needs a full manual QA prior to being added to a release. Run Smoke E2E Triggers smoke e2e on Bitrise team-mobile-ux DEPRECATED: please use "team-wallet-ux" label instead
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants