Skip to content

chore: add tests for keccak256 utf8 input #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 25, 2025
Merged

chore: add tests for keccak256 utf8 input #33

merged 1 commit into from
Nov 25, 2025

Conversation

@Nodonisko
Copy link
Contributor

@Nodonisko Nodonisko commented Nov 25, 2025

Add tests to ensure that our implementation accepts string as plain UTF8 string.

@Nodonisko Nodonisko requested a review from a team as a code owner November 25, 2025 22:22
@Nodonisko Nodonisko mentioned this pull request Nov 25, 2025
Merged
sethkfman pushed a commit that referenced this pull request Nov 25, 2025
@Nodonisko
Fix: treat keccak256 string input as utf8 not hex (#32)
0905bba 
I did mistake and assumed that hex string input should be hex encoded
bytes, but @noble which we are want to polyfill treats hex string as
plain UTF8 string, not hex encoded bytes.

Tests in separate PR: #33
sethkfman
sethkfman approved these changes Nov 25, 2025
View reviewed changes
Copy link
Contributor

@sethkfman sethkfman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sethkfman sethkfman merged commit c489b38 into MetaMask:main Nov 25, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sethkfman sethkfman sethkfman approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Nodonisko @sethkfman