test(extension): Add object registry e2e tests.#555
Merged
Conversation
sirtimid
reviewed
Jun 26, 2025
Comment on lines
+31
to
+36
| test('should send a message to an object', async () => { | ||
| const response = await sendMessage(popupPage, target, method, params); | ||
| await expect(response).toContainText(/body(.+):(.+)hello(.+)from(.+)Bob/u); | ||
| }); | ||
|
|
||
| test('should revoke an object', async () => { |
Member
There was a problem hiding this comment.
these could be one test though and you can move the should send a message to a vat from packages/extension/test/e2e/control-panel.test.ts here :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds e2e coverage for the object registry, covering the following.
Bonus: forwards command line arguments from
yarn test:e2e:cito the underlyingyarn playwright testcommand.