From abe5856cd84400195b71f5b03377963df5b026b9 Mon Sep 17 00:00:00 2001 From: Richard Henkenjohann Date: Tue, 31 Mar 2020 20:36:28 +0200 Subject: [PATCH] Revert "Fix "allow preview" for published filter setting." This reverts commit 03bc2064183f0574a1c05d8d0b50c67cd7416e22. --- .../FilterSettingTypeFactory.php | 20 ++++--------------- src/FilterSetting/Published.php | 17 +++------------- src/Resources/config/services.yml | 1 - 3 files changed, 7 insertions(+), 31 deletions(-) diff --git a/src/FilterSetting/FilterSettingTypeFactory.php b/src/FilterSetting/FilterSettingTypeFactory.php index 78fb261..b445ef2 100644 --- a/src/FilterSetting/FilterSettingTypeFactory.php +++ b/src/FilterSetting/FilterSettingTypeFactory.php @@ -3,7 +3,7 @@ /** * This file is part of MetaModels/attribute_checkbox. * - * (c) 2012-2019 The MetaModels team. + * (c) 2012-2020 The MetaModels team. * * For the full copyright and license information, please view the LICENSE * file that was distributed with this source code. @@ -15,14 +15,13 @@ * @author Sven Baumann * @author David Molineus * @author Richard Henkenjohann - * @copyright 2012-2019 The MetaModels team. + * @copyright 2012-2020 The MetaModels team. * @license https://github.com/MetaModels/attribute_checkbox/blob/master/LICENSE LGPL-3.0-or-later * @filesource */ namespace MetaModels\AttributeCheckboxBundle\FilterSetting; -use Contao\CoreBundle\Security\Authentication\Token\TokenChecker; use Doctrine\DBAL\Connection; use MetaModels\Filter\FilterUrlBuilder; use MetaModels\Filter\Setting\AbstractFilterSettingTypeFactory; @@ -54,26 +53,17 @@ class FilterSettingTypeFactory extends AbstractFilterSettingTypeFactory */ private $filterUrlBuilder; - /** - * The token checker. - * - * @var TokenChecker - */ - private $tokenChecker; - /** * Create a new instance. * * @param Connection $connection The database connection. * @param EventDispatcherInterface|null $dispatcher The event dispatcher. * @param FilterUrlBuilder|null $filterUrlBuilder The filter URL builder. - * @param TokenChecker|null $tokenChecker The token checker. */ public function __construct( Connection $connection, EventDispatcherInterface $dispatcher = null, - FilterUrlBuilder $filterUrlBuilder = null, - TokenChecker $tokenChecker = null + FilterUrlBuilder $filterUrlBuilder = null ) { parent::__construct(); @@ -86,7 +76,6 @@ public function __construct( $this->connection = $connection; $this->dispatcher = $dispatcher; $this->filterUrlBuilder = $filterUrlBuilder; - $this->tokenChecker = $tokenChecker; } /** @@ -99,8 +88,7 @@ public function createInstance($information, $filterSettings) $information, $this->connection, $this->dispatcher, - $this->filterUrlBuilder, - $this->tokenChecker + $this->filterUrlBuilder ); } } diff --git a/src/FilterSetting/Published.php b/src/FilterSetting/Published.php index 841b656..c6342ea 100644 --- a/src/FilterSetting/Published.php +++ b/src/FilterSetting/Published.php @@ -23,7 +23,6 @@ namespace MetaModels\AttributeCheckboxBundle\FilterSetting; -use Contao\CoreBundle\Security\Authentication\Token\TokenChecker; use Contao\System; use Doctrine\DBAL\Connection; use MetaModels\Filter\FilterUrlBuilder; @@ -46,13 +45,6 @@ class Published extends Simple */ private $connection; - /** - * The token checker. - * - * @var TokenChecker - */ - private $tokenChecker; - /** * Constructor - initialize the object and store the parameters. * @@ -61,15 +53,13 @@ class Published extends Simple * @param Connection $connection The database connection. * @param EventDispatcherInterface|null $dispatcher The event dispatcher. * @param FilterUrlBuilder|null $filterUrlBuilder The filter URL builder. - * @param TokenChecker|null $tokenChecker The token checker. */ public function __construct( ICollection $collection, array $data, Connection $connection = null, EventDispatcherInterface $dispatcher = null, - FilterUrlBuilder $filterUrlBuilder = null, - TokenChecker $tokenChecker = null + FilterUrlBuilder $filterUrlBuilder = null ) { parent::__construct($collection, $data, $dispatcher, $filterUrlBuilder); @@ -84,8 +74,7 @@ public function __construct( $connection = System::getContainer()->get('database_connection'); } - $this->connection = $connection; - $this->tokenChecker = $tokenChecker; + $this->connection = $connection; } /** @@ -98,7 +87,7 @@ public function prepareRules(IFilter $objFilter, $arrFilterUrl) } // Skip filter when in front end preview. - if ($this->get('check_allowpreview') && ($this->tokenChecker && $this->tokenChecker->isPreviewMode())) { + if ($this->get('check_allowpreview') && BE_USER_LOGGED_IN) { return; } diff --git a/src/Resources/config/services.yml b/src/Resources/config/services.yml index a4aff85..9b9a5ed 100644 --- a/src/Resources/config/services.yml +++ b/src/Resources/config/services.yml @@ -13,6 +13,5 @@ services: - '@database_connection' - '@event_dispatcher' - '@MetaModels\Filter\FilterUrlBuilder' - - '@contao.security.token_checker' tags: - { name: metamodels.filter_factory }