Fix the translations for languages the same as the content language #1489
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue fixed: 1. Site language set to English and user creates/writes an English question, with its content at version **V1** (Google Translated detected it also as English content). 2. User changes the language to “Untranslated” 3. User makes more edits to the content, bringing it to **V2** 4. User changes the language back to English (doesn’t edit!) and content is now at **V1**. But for all the other languages, including the “Untranslated”, content is **V2**. 5. The issue is that the platform was detecting the content as being English and was not updating the English column (e.g.: `title_en`) because it was wrongly relying on the Default language mechanism to use the content from the `title_original` given that the language of the content was English. But that only happens if the `title_en` was empty, and here it was not the case, as the question was initially written in English, so it’s `*_en` columns were populated. It’s only the case for content never translated.
hlbmtc
approved these changes
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue fixed:
title_en) because it was wrongly relying on the Default language mechanism to use the content from thetitle_originalgiven that the language of the content was English. But that only happens if thetitle_enwas empty, and here it was not the case, as the question was initially written in English, so it’s*_encolumns were populated. It’s only the case for content never translated.