Skip to content

issue/4164/fix/mc-choices-hidden#4283

Merged
lsabor merged 2 commits intomainfrom
issue/4164/fix/mc-choices-label-pre-cp-reveal
Feb 8, 2026
Merged

issue/4164/fix/mc-choices-hidden#4283
lsabor merged 2 commits intomainfrom
issue/4164/fix/mc-choices-label-pre-cp-reveal

Conversation

@lsabor
Copy link
Contributor

@lsabor lsabor commented Feb 8, 2026

closes #4164
for MC choice labels in consumer view, differentiates between upcoming and hidden by cp reveal time

Summary by CodeRabbit

  • Localization
    • Added a new "hidden" label translation for Czech, English, Spanish, Portuguese, Traditional Chinese, and Simplified Chinese.
  • User Interface
    • Forecast card display now uses the new "hidden" label where applicable (e.g., when reveal time is in the future).

closes #4164
replaces 'Upcoming' with 'Hidden'
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 8, 2026

📝 Walkthrough

Walkthrough

Adds a new "hidden" localization key in six front-end message files and updates the percentage forecast card component to use the new t("hidden") label for empty forecast values when the CP reveal time is in the future.

Changes

Cohort / File(s) Summary
Translation Keys
front_end/messages/cs.json, front_end/messages/en.json, front_end/messages/es.json, front_end/messages/pt.json, front_end/messages/zh-TW.json, front_end/messages/zh.json
Added a new top-level translation key "hidden" with localized values in each language file.
Component Update
front_end/src/components/consumer_post_card/group_forecast_card/percentage_forecast_card.tsx
Compute emptyLabel using CP reveal time and replace literal t("Upcoming") with t("hidden"); added emptyLabel to memo dependencies and passed it to getPredictionDisplayValue.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Suggested reviewers

  • elisescu
  • hlbmtc
  • cemreinanc

Poem

🐰 I nibble keys in moonlit night,
"Hidden" hops in, snug and light,
Six tongues whisper what I sing,
Quiet label, gentle spring,
A rabbit cheers — the UI's bright! 🥕✨

🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The PR title references issue #4164 and indicates a fix for MC choices label, directly aligning with the main objective to change 'Upcoming' to 'Hidden' before CP reveal.
Linked Issues check ✅ Passed The code changes correctly implement the requirement to replace 'Upcoming' with 'Hidden' for MC choices before CP reveal [#4164], adding translations and updating component logic accordingly.
Out of Scope Changes check ✅ Passed All changes directly support the objective of fixing MC choice labels based on CP reveal state; translation additions and component logic updates are entirely within scope.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch issue/4164/fix/mc-choices-label-pre-cp-reveal

No actionable comments were generated in the recent review. 🎉


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 8, 2026

🧹 Preview Environment Cleaned Up

The preview environment for this PR has been destroyed.

Resource Status
🌐 Preview App ✅ Deleted
🗄️ PostgreSQL Branch ✅ Deleted
⚡ Redis Database ✅ Deleted
🔧 GitHub Deployments ✅ Removed
📦 Docker Image ⚠️ Retained (auto-cleanup via GHCR policies)

Cleanup triggered by PR close at 2026-02-08T22:26:19Z

@lsabor lsabor merged commit 41ea01d into main Feb 8, 2026
14 checks passed
@lsabor lsabor deleted the issue/4164/fix/mc-choices-label-pre-cp-reveal branch February 8, 2026 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

MC choices appear as "upcoming" before CP is revealed - should be "hidden"

1 participant