New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v7.0.0 #1694
v7.0.0 #1694
Conversation
This pull request fixes 14 alerts when merging 13cba36 into d8f8b6a - view on LGTM.com fixed alerts:
|
This pull request fixes 14 alerts when merging 03fbe07 into d8f8b6a - view on LGTM.com fixed alerts:
|
This package is now ready to be published, I am just waiting to get the themes to be published first and then we can finally make it official. |
This pull request fixes 14 alerts when merging 54df731 into d8f8b6a - view on LGTM.com fixed alerts:
|
This pull request fixes 14 alerts when merging d06fb05 into d8f8b6a - view on LGTM.com fixed alerts:
|
This PR finalizes the rewrite from #1693 on this repo's
v7-dev
branch. This includes proper update of the mentioned issues from #1693, a solid testing and a great and updated documentation.What's the goal with v7?
This version improves performance a lot, while at the same time reducing bundle size. No underscore anymore and the (outdated BS3) templates are now decoupled from the package, so you are highly flexible in choosing a theme template for your forms.
Also the list of extensions is curated to highlight deprecated/abandoned packages.
Why not finalize in #1693 ?
The #1693 was done by @pouya-eghbali (great job!) and come from his fork. In order to allow multiple contributions on v7 without the need of managing a second repo, we just merged it into
v7-dev
and continue to work on this until we have a final version.TODO List from #1693 review
var
with ES6let
orconst
and test of the scoping does not break anythingc
to have meaningful namesindexOf
and -1 comparison on Arrays withincludes
isObject
->export const isObject = obj => Object.prototype.toString.call(obj) === '[object Object]'
meteortesting:mocha
v2Additional bugs to fix, introduced with this PR:
Post-release things to do
moment
a weak dependency, replace it with luxon / day.s or even with native Date?meteor-build-client
) to publish in GitHub pagesHow can I help?
We need reviewers and testers as much as possible to make this a stable version. Breaking changes and breaking compatibility with extensions need to be documented, as well as newly added functions. Tests should be added where possible.