Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v7.0.0 #1694

Merged
merged 170 commits into from Nov 25, 2020
Merged

v7.0.0 #1694

merged 170 commits into from Nov 25, 2020

Conversation

jankapunkt
Copy link
Member

@jankapunkt jankapunkt commented Jun 18, 2020

This PR finalizes the rewrite from #1693 on this repo's v7-dev branch. This includes proper update of the mentioned issues from #1693, a solid testing and a great and updated documentation.

What's the goal with v7?

This version improves performance a lot, while at the same time reducing bundle size. No underscore anymore and the (outdated BS3) templates are now decoupled from the package, so you are highly flexible in choosing a theme template for your forms.

Also the list of extensions is curated to highlight deprecated/abandoned packages.

Why not finalize in #1693 ?

The #1693 was done by @pouya-eghbali (great job!) and come from his fork. In order to allow multiple contributions on v7 without the need of managing a second repo, we just merged it into v7-dev and continue to work on this until we have a final version.

TODO List from #1693 review

  • replace all var with ES6 let or const and test of the scoping does not break anything
  • rename unclear variables, like c to have meaningful names
  • replace indexOf and -1 comparison on Arrays with includes
  • isObject -> export const isObject = obj => Object.prototype.toString.call(obj) === '[object Object]'
  • check for double/multiple declared functions and merge them into a single export
  • Testing: update testing suite to meteortesting:mocha v2
  • Testing: introduce GitHub actions to make CI maintenance easier
  • allow dynamic imports via process.env flag without break actual functionality
  • the API docs need to be rebuild, since there are updated / changed jsDoc comments in the code

Additional bugs to fix, introduced with this PR:

Post-release things to do

  • Discussion: make moment a weak dependency, replace it with luxon / day.s or even with native Date?
  • The documentation needs to be updated (review outdated extensions, remove links to the old demo)
  • The demo has been shut down, so we need a good usable demo (using npm meteor-build-client) to publish in GitHub pages

How can I help?

We need reviewers and testers as much as possible to make this a stable version. Breaking changes and breaking compatibility with extensions need to be documented, as well as newly added functions. Tests should be added where possible.

@lgtm-com
Copy link

@lgtm-com lgtm-com bot commented Nov 24, 2020

This pull request fixes 14 alerts when merging 13cba36 into d8f8b6a - view on LGTM.com

fixed alerts:

  • 9 for Superfluous trailing arguments
  • 3 for Unused variable, import, function or class
  • 1 for Missing variable declaration
  • 1 for Prototype pollution in utility function

@lgtm-com
Copy link

@lgtm-com lgtm-com bot commented Nov 24, 2020

This pull request fixes 14 alerts when merging 03fbe07 into d8f8b6a - view on LGTM.com

fixed alerts:

  • 9 for Superfluous trailing arguments
  • 3 for Unused variable, import, function or class
  • 1 for Missing variable declaration
  • 1 for Prototype pollution in utility function

@jankapunkt
Copy link
Member Author

@jankapunkt jankapunkt commented Nov 24, 2020

This package is now ready to be published, I am just waiting to get the themes to be published first and then we can finally make it official.

@lgtm-com
Copy link

@lgtm-com lgtm-com bot commented Nov 24, 2020

This pull request fixes 14 alerts when merging 54df731 into d8f8b6a - view on LGTM.com

fixed alerts:

  • 9 for Superfluous trailing arguments
  • 3 for Unused variable, import, function or class
  • 1 for Missing variable declaration
  • 1 for Prototype pollution in utility function

@lgtm-com
Copy link

@lgtm-com lgtm-com bot commented Nov 25, 2020

This pull request fixes 14 alerts when merging d06fb05 into d8f8b6a - view on LGTM.com

fixed alerts:

  • 9 for Superfluous trailing arguments
  • 3 for Unused variable, import, function or class
  • 1 for Missing variable declaration
  • 1 for Prototype pollution in utility function

@jankapunkt jankapunkt merged commit d60915c into devel Nov 25, 2020
2 checks passed
Blaze packages automation moved this from In progress to Done Nov 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

3 participants