Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't compile locally using Windows preview #64

Closed
fredrikekelund opened this Issue Jan 30, 2015 · 15 comments

Comments

Projects
None yet
4 participants
@fredrikekelund
Copy link

fredrikekelund commented Jan 30, 2015

Official Meteor support for Windows is right around the corner and I'm testing the preview they've published. I've encountered an error when adding fourseven:scss as a local package - I get the following error:

While loading plugin `scss` from package `scss`:

C:\Git\MeteorDataTool\meteor\packages\scss\.npm\plugin\scss\node_modules\node-sass\lib\index.js:21:11:
`libsass` bindings not found. Try reinstalling `node-sass`?
at getBinding
(C:\Git\MeteorDataTool\meteor\packages\scss\.npm\plugin\scss\node_modules\node-sass\lib\index.js:21:11)
at Object.<anonymous>
(C:\Git\MeteorDataTool\meteor\packages\scss\.npm\plugin\scss\node_modules\node-sass\lib\index.js:211:23)
at Module._compile (module.js:456:26)
at Object.Module._extensions..js (module.js:474:10)
at Module.load (module.js:356:32)
at Function.Module._load (module.js:312:12)
at Module.require (module.js:364:17)
at require (module.js:380:17)
at Object._.extend.Npm.require
(C:\Users\Fredrik\AppData\Local\.meteor\packages\meteor-tool\1.1.0-winr.0\mt-os.windows.x86_32\tools\bundler.js:1331:22)
at Package (packages/scss/plugin/compile-scss.js:2:1)
at <runJavaScript-80>:119:4
at <runJavaScript-80>:126:3

The relevant line probably being libsass bindings not found. Try reinstalling node-sass?

While this is an error thrown by node-sass and not fourseven:scss, it seems to be an issue specifically when node-sass is installed by Meteor, since I can install it elsewhere on my system using just npm and it works fine.

I'd be happy to help fix this, but I was wondering if you (or anyone) has an idea of what could cause this problem?

@fourseven

This comment has been minimized.

Copy link
Collaborator

fourseven commented Jan 30, 2015

Honestly, the platform specific build chain doesn't support windows yet - so I'm not surprised that the released packages don't support it. Are their build boxes for windows in beta?

@fredrikekelund

This comment has been minimized.

Copy link
Author

fredrikekelund commented Jan 30, 2015

Nope, no build boxes yet. I suppose you have a point, they haven't said anything about what they intend to do with binary packages for Windows, so there might be further support for that in the works.

But still, a lot of npm packages do compile properly when wrapped in a Meteor package, so I thought I'd raise the question to see what to make of it in this case

@fourseven

This comment has been minimized.

Copy link
Collaborator

fourseven commented Feb 2, 2015

I'll have a poke around this week and see what I can find. Which version of the scss package are you installing?

@fredrikekelund

This comment has been minimized.

Copy link
Author

fredrikekelund commented Feb 3, 2015

Cool! I downloaded the repo at the latest version (2.0.0-beta2 at the time, I believe) and added it as a local package.

@fredrikekelund

This comment has been minimized.

Copy link
Author

fredrikekelund commented Feb 3, 2015

I tried raising a general question around binary packages and Windows in the windows preview issue tracker, but haven't gotten any response there yet.

@fredrikekelund

This comment has been minimized.

Copy link
Author

fredrikekelund commented Feb 5, 2015

It seems that the node binary that comes bundled with Meteor is 32-bit. I'm not sure whether this is what causes the problem, but at the same time I can see that the node-sass package seems to be downloading libsass bindings for 64-bit (which is what my OS, which is Windows 8.1 btw, is running).

@dandv

This comment has been minimized.

Copy link

dandv commented Mar 6, 2015

I get as well

While checking for fourseven:scss@2.0.0_1
error: No compatible build found

I have a Windows machine. How can I help?

BTW there have been some updates in https://github.com/meteor/windows-preview/issues/45

@fredrikekelund

This comment has been minimized.

Copy link
Author

fredrikekelund commented Mar 16, 2015

The Meteor team published a release candidate (0.3.0) the other day, and some advice for packages with binary dependencies as well as regarding generally publishing packages cross platform. Have you had a chance to try to publish the package with the latest Meteor?

@fourseven

This comment has been minimized.

Copy link
Collaborator

fourseven commented Mar 17, 2015

I'll have a look this weekend. I got very burned by this last time I tried (hence why there's a 2.0.1_1 and 2.0.1_2 release) so I'll see how it goes this time around.

@fourseven

This comment has been minimized.

Copy link
Collaborator

fourseven commented Mar 17, 2015

Since it's starting to gain traction, here's where it's failing now. https://github.com/meteor/windows-preview/issues/108 - This is a WIP, hope to have a working version eventually.

@fourseven

This comment has been minimized.

Copy link
Collaborator

fourseven commented Mar 17, 2015

@fourseven

This comment has been minimized.

Copy link
Collaborator

fourseven commented Mar 25, 2015

Hah just realised we'd be discussing the same issue @fredrikekelund - do you have a windows box to test fourseven:scss@2.0.1_5? If it works I will close this (it's published, don't have a windows box handy though).

@fredrikekelund

This comment has been minimized.

Copy link
Author

fredrikekelund commented Mar 25, 2015

Haha yeah, I've been eager to see this fixed.

It works, both downloading it and using it 🎉 Actually it works even if I'm using WINDOWS-PREVIEW@0.3.0 to run the app

@jakobrosenberg

This comment has been minimized.

Copy link

jakobrosenberg commented Mar 25, 2015

Works for me now. Thanks!

@fourseven

This comment has been minimized.

Copy link
Collaborator

fourseven commented Mar 25, 2015

Cool 🎈

@fourseven fourseven closed this Mar 25, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.