Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kinect 4 Azure #197

Merged
merged 38 commits into from Jul 3, 2019

Conversation

Projects
None yet
2 participants
@jangernert
Copy link
Collaborator

commented Jun 19, 2019

Todo: wait for stable Util release with ProjectiveTransformationRational

@jangernert jangernert requested a review from sisiplac Jun 19, 2019

@jangernert jangernert force-pushed the kinect_azure branch from 2348571 to 1369725 Jun 19, 2019

jangernert and others added some commits Jun 19, 2019

@jangernert jangernert force-pushed the kinect_azure branch from 905a4f0 to 9fcac28 Jun 28, 2019

@sisiplac

This comment has been minimized.

Copy link
Contributor

commented Jul 1, 2019

Two ideas to discuss:

  1. What do you think about setting the ColorResolution or the DepthMode to off, if the corresponding DeactivateChannelmethods are called? In that case we would need to keep the last valid resolution / depth mode in memory.
  2. I would prefer to delete the channel Distance and to only support native channels (the computation of radial distances based on 3D data is very expensive).

@sisiplac sisiplac changed the title [WIP] Kinect 4 Azure Kinect 4 Azure Jul 3, 2019

@sisiplac
Copy link
Contributor

left a comment

Everything is fine now from my point of view.

@sisiplac sisiplac merged commit 72128c0 into master Jul 3, 2019

1 check passed

MetriCam2 CI Build successful
Details

@sisiplac sisiplac deleted the kinect_azure branch Jul 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.