Skip to content

Clean up Among Them roster checks#175

Merged
relh merged 1 commit into
masterfrom
relh/amongthem-roster-cleanup-ci
May 14, 2026
Merged

Clean up Among Them roster checks#175
relh merged 1 commit into
masterfrom
relh/amongthem-roster-cleanup-ci

Conversation

@relh
Copy link
Copy Markdown
Contributor

@relh relh commented May 14, 2026

Summary

  • Removes the duplicated pre-upgrade roster auth and duplicate-player checks added around Tighten Among Them token roster joins #170.
  • Keeps the runtime contract simple: /player records the requested identity, slot, and token; sim.addPlayer owns slot/token/occupancy/closed-roster validation.
  • Keeps token-to-configured-name derivation for hosted joins and a clearer closed-roster-full error from the sim.

Why

Andre's concern on #170 was right: the server should not carry a second copy of the roster contract. If a player join is explicit via slot/token, the server now upgrades the websocket and lets the sim join path either accept it or close it. Anonymous extra viewers can still fall back to the existing spectator path.

Verification

  • nim c among_them/among_them.nim
  • Branch-local closed-roster E2E server: valid slot=0&token=crew-token and slot=1&token=imp-token stayed connected.
  • Same server closed duplicate slot 0, bad token, and outside-roster explicit joins through the sim join path.
  • Full local Coworld episode using branch-built bitworld-among-them-runner:pr175-e2e-5ca8b0b passed with coworld run-episode /tmp/bitworld-pr175-coworld_manifest.json --output-dir /tmp/bitworld-pr175-e2e --timeout-seconds 600 --verify-replay after the runner compatibility fix in Metta PR https://github.com/Metta-AI/metta/pull/13399.
  • git diff --check

@relh relh force-pushed the relh/amongthem-roster-cleanup-ci branch from ddb3ffa to e02f9e4 Compare May 14, 2026 20:07
@relh relh force-pushed the relh/amongthem-roster-cleanup-ci branch from e02f9e4 to 5ca8b0b Compare May 14, 2026 20:18
@relh relh merged commit 3f2ad2a into master May 14, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant