Clean up Among Them roster checks#175
Merged
Merged
Conversation
ddb3ffa to
e02f9e4
Compare
e02f9e4 to
5ca8b0b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/playerrecords the requested identity, slot, and token;sim.addPlayerowns slot/token/occupancy/closed-roster validation.Why
Andre's concern on #170 was right: the server should not carry a second copy of the roster contract. If a player join is explicit via slot/token, the server now upgrades the websocket and lets the sim join path either accept it or close it. Anonymous extra viewers can still fall back to the existing spectator path.
Verification
nim c among_them/among_them.nimslot=0&token=crew-tokenandslot=1&token=imp-tokenstayed connected.bitworld-among-them-runner:pr175-e2e-5ca8b0bpassed withcoworld run-episode /tmp/bitworld-pr175-coworld_manifest.json --output-dir /tmp/bitworld-pr175-e2e --timeout-seconds 600 --verify-replayafter the runner compatibility fix in Metta PR https://github.com/Metta-AI/metta/pull/13399.git diff --check