Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integer overflows in the led driver of the daisy-o-oss branch #973

Open
leoaccount opened this Issue Nov 18, 2018 · 0 comments

Comments

Projects
None yet
1 participant
@leoaccount
Copy link

leoaccount commented Nov 18, 2018

There are several suspected integer overflow bugs in drivers/leds/leds-aw2023.c, line 299 & 302 & 348 & 351. The led id may be equal to or greater than the integer length (depends on the target arch), which causes integer overflow when using the left shift operation "1 << led->id". Possible solution for this case would be to cast the integer "1" to a data type of larger length before shifting it with led->id.

@leoaccount leoaccount closed this Nov 25, 2018

@leoaccount leoaccount reopened this Dec 7, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.