Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update user_io.cpp #351

Closed
wants to merge 1 commit into from
Closed

Conversation

@rikard-softgear
Copy link
Contributor

@rikard-softgear rikard-softgear commented Feb 15, 2021

Use all progress chars to render the progress bar.

Use all progress chars to render the progress bar.
@sorgelig
Copy link
Member

@sorgelig sorgelig commented Feb 15, 2021

More chars may slow down loading.

@rikard-softgear
Copy link
Contributor Author

@rikard-softgear rikard-softgear commented Feb 15, 2021

I didn't notice such a thing.

@birdybro
Copy link

@birdybro birdybro commented Mar 26, 2021

Tested with Final Fantasy Tactics Advance with GBA core (long load time for this game). No major difference in load times (the equivalent of being 2 frames ahead of the load animation by the end for the original, but I have not ruled out this being influenced by variation of load times if there are any, due to microSD and other factors).

fftacomparison.mp4

Tested with a much smaller game, Sonic 2 for Sega Genesis, again no real difference in load times that I can tell.

sonic2comparison.mp4

I see no evidence that this increases load times in any serious way.

EDIT: forgive my crappy video editing skills, these are not synced to an exact frame perfectly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants