Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Large mapper 28 sizes are unsupported #250

Closed
retroalarm opened this issue May 3, 2021 · 2 comments
Closed

Large mapper 28 sizes are unsupported #250

retroalarm opened this issue May 3, 2021 · 2 comments

Comments

@retroalarm
Copy link

@retroalarm retroalarm commented May 3, 2021

The large .NES files from Action 53 Vol, 3 and 4 available from https://action53.itch.io/ do not load. Likely because the core does not support a huge file size for this.

@sorgelig
Copy link
Member

@sorgelig sorgelig commented May 4, 2021

Multigames carts on core is IMHO useless. Each such 999in1 cart may introduce its own mapper without any real benefit except just map of those included games to a virtual cart. Just find each game separately. I don't think it worth to spend effort and FPGA resources for something which is working in other cart version.

@greyrogue
Copy link
Contributor

@greyrogue greyrogue commented May 7, 2021

For what it's worth, I think the fix is just removing the bit mask from this line.
https://github.com/MiSTer-devel/NES_MiSTer/blob/master/rtl/mappers/generic.sv#L1142
It was intended to make it more accurate to original hardware boards that maxed out at 256K (although the mask there is for 512K, I think). Since the ROM size indicates non-original hardware boards won't work anyway, forcing the mask isn't really required.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants