Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build & clean scripts broken. #12

Closed
ArcadeHustle opened this issue Mar 30, 2021 · 6 comments
Closed

Build & clean scripts broken. #12

ArcadeHustle opened this issue Mar 30, 2021 · 6 comments

Comments

@michaelshmitty
Copy link
Member

@michaelshmitty michaelshmitty commented Mar 30, 2021

It's there when you provision the VM using Vagrant.
https://github.com/MiSTer-devel/mr-fusion/blob/master/Vagrantfile#L130

Not sure what the issue is exactly, nor what you're implying with the referenced material. Either elaborate, file a more complete error report or propose a PR with a fix.
Thanks!

@birdybro
Copy link

@birdybro birdybro commented Mar 30, 2021

redacting my initial comment :)

@michaelshmitty
Copy link
Member

@michaelshmitty michaelshmitty commented Mar 30, 2021

That won't be necessary @birdybro , I will resolve the issue.
@ArcadeHustle this will be addressed as soon as possible. Thanks for filing.

@ArcadeHustle
Copy link
Author

@ArcadeHustle ArcadeHustle commented Mar 30, 2021

Thanks @michaelshmitty, I was indeed not using Vagrant.

@michaelshmitty
Copy link
Member

@michaelshmitty michaelshmitty commented Mar 30, 2021

@ArcadeHustle even so, you may still have a point even if you're not using vagrant. We are releasing binary versions of mr-fusion and after carefully reading the material you have linked, it may be the intention of the buildroot developers to have the buildroot source and config included in this repo. I will take care of that as soon as possible. Thanks again for bringing attention to this.

michaelshmitty added a commit that referenced this issue Mar 31, 2021
@mikegreiling
Copy link

@mikegreiling mikegreiling commented Mar 31, 2021

Thank you very much for this 💯

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants