Revert "more readable exception handling _connect_tcp()" #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit da8cb1a. It turned out that da8cb1 actually changed the API of python-mpd: if an error occurred while connecting to the MPD server, MPDClient._connect_tcp() would always return 'ConnectionError("getaddrinfo returns an empty list"), even if getaddrinfo() actually returned something. I have no idea how to make getaddrinfo() returns nothing, so it's hard to test at the moment. Conflicts: test.py
Mic92
added a commit
that referenced
this pull request
Mar 20, 2012
Revert "more readable exception handling _connect_tcp()"
Mic92
pushed a commit
that referenced
this pull request
Nov 21, 2018
Merge master to include commit adding close method for AsyncMockServer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit da8cb1a.
It turned out that da8cb1 actually changed the API of python-mpd: if an error
occurred while connecting to the MPD server, MPDClient._connect_tcp() would always
return 'ConnectionError("getaddrinfo returns an empty list"), even if getaddrinfo()
actually returned something.
I have no idea how to make getaddrinfo() returns nothing, so it's hard to test at
the moment.
Conflicts: