Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gzip encoded calendar urls fail to load #1400

Closed
ubertao opened this issue Sep 8, 2018 · 1 comment
Closed

Gzip encoded calendar urls fail to load #1400

ubertao opened this issue Sep 8, 2018 · 1 comment

Comments

@ubertao
Copy link
Contributor

ubertao commented Sep 8, 2018

Platform: Raspberry Pi 3B+, Electron 2.0.0

Node Version: v9.11.2

MagicMirror Version: v2.4.1

Description:
Some calendar servers (e.g. icloud.com) responses are gzip encoded, calendar module won't load them.

Steps to Reproduce:
Add "https://p33-calendars.icloud.com/holidays/cn_zh.ics" to calendar module.
(Or any url which response is gzip encoded.)

Expected Results:
Calendar module displays the calendar events.

Actual Results:
Calendar always displays "loading".

Configuration:

{
    module: "calendar",
    header: "China Holidays",
    position: "top_left",
    config: {
        calendars: [
            {
                symbol: "calendar-check-o ",
                url: "https://p33-calendars.icloud.com/holidays/cn_zh.ics"
            }
        ]
    }
}
@MichMich
Copy link
Collaborator

Fix merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants